Merge pull request #20312 from geoffw0/dbquality

geoffw0 · web-flow · commit 45d6fc04cef5 · 2025-08-29T13:04:46.000+01:00
Rust: Tune rust/diagnostic/database-quality
diff --git a/rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md b/rust/ql/src/change-notes/2025-08-28-diagnostic-database-quality.md
@@ -0,0 +1,4 @@
+---
+category: fix
+---
+* The "Low Rust analysis quality" query (`rust/diagnostic/database-quality`) has been tuned so that it won't trigger on databases that have extracted normally. This will remove spurious messages of "Low Rust analysis quality" on the CodeQL status page.
diff --git a/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql b/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql
@@ -12,11 +12,9 @@ import codeql.util.Unit
 class DbQualityDiagnostic extends Unit {
   DbQualityDiagnostic() {
     exists(float percentageGood |
-      CallTargetStatsReport::percentageOfOk(_, percentageGood)
+      CallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50
       or
-      MacroCallTargetStatsReport::percentageOfOk(_, percentageGood)
-    |
-      percentageGood < 95
+      MacroCallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50
     )
   }
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: fix
 +---
 +* The "Low Rust analysis quality" query (`rust/diagnostic/database-quality`) has been tuned so that it won't trigger on databases that have extracted normally. This will remove spurious messages of "Low Rust analysis quality" on the CodeQL status page.
Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,9 @@ import codeql.util.Unit`
`12`	`12`	`class DbQualityDiagnostic extends Unit {`
`13`	`13`	`DbQualityDiagnostic() {`
`14`	`14`	`exists(float percentageGood \|`
`15`		`- CallTargetStatsReport::percentageOfOk(_, percentageGood)`
	`15`	`+ CallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50`
`16`	`16`	`or`
`17`		`- MacroCallTargetStatsReport::percentageOfOk(_, percentageGood)`
`18`		`- \|`
`19`		`- percentageGood < 95`
	`17`	`+ MacroCallTargetStatsReport::percentageOfOk(_, percentageGood) and percentageGood < 50`
`20`	`18`	`)`
`21`	`19`	`}`
`22`	`20`