Skip to content

Commit 6ec994e

Browse files
henrymercerhenrymercer
authored
Merge pull request #3039 from github/mbg/remove-cpp-bmn-check
Remove unused C++ BMN FF
2 parents 2330521 + 3f00c7c commit 6ec994e

File tree

6 files changed

+2
-32
lines changed

6 files changed

+2
-32
lines changed

‎lib/feature-flags.js

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/feature-flags.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/init-action.js

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/init-action.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/feature-flags.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export interface FeatureEnablement {
4444
*/
4545
export enum Feature {
4646
CleanupTrapCaches = "cleanup_trap_caches",
47-
CppBuildModeNone = "cpp_build_mode_none",
4847
CppDependencyInstallation = "cpp_dependency_installation_enabled",
4948
DiffInformedQueries = "diff_informed_queries",
5049
DisableCsharpBuildless = "disable_csharp_buildless",
@@ -112,11 +111,6 @@ export const featureConfig: Record<
112111
envVar: "CODEQL_ACTION_CLEANUP_TRAP_CACHES",
113112
minimumVersion: undefined,
114113
},
115-
[Feature.CppBuildModeNone]: {
116-
defaultValue: false,
117-
envVar: "CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE",
118-
minimumVersion: undefined,
119-
},
120114
[Feature.CppDependencyInstallation]: {
121115
defaultValue: false,
122116
envVar: "CODEQL_EXTRACTOR_CPP_AUTOINSTALL_DEPENDENCIES",

‎src/init-action.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -646,16 +646,6 @@ async function run() {
646646
}
647647
}
648648

649-
// Set CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE
650-
if (config.languages.includes(KnownLanguage.cpp)) {
651-
const bmnVar = "CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE";
652-
const value =
653-
process.env[bmnVar] ||
654-
(await features.getValue(Feature.CppBuildModeNone, codeql));
655-
logger.info(`Setting C++ build-mode: none to ${value}`);
656-
core.exportVariable(bmnVar, value);
657-
}
658-
659649
// Restore dependency cache(s), if they exist.
660650
if (shouldRestoreCache(config.dependencyCachingEnabled)) {
661651
await downloadDependencyCaches(config.languages, logger);

0 commit comments

Comments
 (0)