Passing saved attributes is optional

dgraham · dgraham · commit 1392d570f431 · 2020-01-21T13:05:59.000-07:00
diff --git a/src/attachment.ts b/src/attachment.ts
@@ -51,14 +51,14 @@ export default class Attachment {
     this.percent = percent
   }
 
-  saved(attributes: {id?: string | null; href?: string | null; name?: string | null}) {
+  saved(attributes?: {id?: string | null; href?: string | null; name?: string | null}) {
     if (this.state !== 'pending' && this.state !== 'saving') {
       throw new Error(`Unexpected transition from ${this.state} to saved`)
     }
     this.state = 'saved'
-    this.id = attributes.id
-    this.href = attributes.href
-    this.name = attributes.name
+    this.id = attributes?.id
+    this.href = attributes?.href
+    this.name = attributes?.name
   }
 
   isPending(): boolean {

Original file line number	Diff line number	Diff line change
`@@ -51,14 +51,14 @@ export default class Attachment {`
`51`	`51`	`this.percent = percent`
`52`	`52`	`}`
`53`	`53`
`54`		`- saved(attributes: {id?: string \| null; href?: string \| null; name?: string \| null}) {`
	`54`	`+ saved(attributes?: {id?: string \| null; href?: string \| null; name?: string \| null}) {`
`55`	`55`	`if (this.state !== 'pending' && this.state !== 'saving') {`
`56`	`56`	throw new Error(`Unexpected transition from ${this.state} to saved`)
`57`	`57`	`}`
`58`	`58`	`this.state = 'saved'`
`59`		`- this.id = attributes.id`
`60`		`- this.href = attributes.href`
`61`		`- this.name = attributes.name`
	`59`	`+ this.id = attributes?.id`
	`60`	`+ this.href = attributes?.href`
	`61`	`+ this.name = attributes?.name`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`isPending(): boolean {`