add better memory usage calculation

mattdholloway · mattdholloway · commit 5a76cbd40837 · 2025-08-13T09:52:44.000+01:00
diff --git a/pkg/github/actions.go b/pkg/github/actions.go
@@ -758,29 +758,34 @@ func downloadLogContent(logURL string, tailLines int) (string, int, *http.Respon
 		tailLines = 1000
 	}
 
-	const maxMemoryBytes = 1024 * 1024 // 1MB memory limit
+	const maxMemoryBytes = 1024 * 1024
 	var lines []string
-	var currentMemoryUsage int
 	totalLines := 0
 
+	calculateMemoryUsage := func() int {
+		total := 0
+		for _, line := range lines {
+			total += len(line) + 1
+		}
+		return total
+	}
+
 	scanner := bufio.NewScanner(httpResp.Body)
 	scanner.Buffer(make([]byte, 0, 64*1024), 1024*1024)
 
 	for scanner.Scan() {
 		line := scanner.Text()
 		totalLines++
-		lineSize := len(line) + 1 // +1 for newline character
+		lineSize := len(line) + 1
 
+		currentMemoryUsage := calculateMemoryUsage()
 		if currentMemoryUsage+lineSize > maxMemoryBytes {
-			for currentMemoryUsage+lineSize > maxMemoryBytes && len(lines) > 0 {
-				removedLineSize := len(lines[0]) + 1
-				currentMemoryUsage -= removedLineSize
+			for calculateMemoryUsage()+lineSize > maxMemoryBytes && len(lines) > 0 {
 				lines = lines[1:]
 			}
 		}
 
 		lines = append(lines, line)
-		currentMemoryUsage += lineSize
 	}
 
 	if err := scanner.Err(); err != nil {
