change minimal_output to use new OptionalBoolParamWithDefault

mattdholloway · mattdholloway · commit 9ea0ac92536b · 2025-08-28T15:34:09.000+01:00
diff --git a/pkg/github/search.go b/pkg/github/search.go
@@ -41,13 +41,10 @@ func SearchRepositories(getClient GetClientFn, t translations.TranslationHelperF
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			minimalOutput, err := OptionalParam[bool](request, "minimal_output")
+			minimalOutput, err := OptionalBoolParamWithDefault(request, "minimal_output", true)
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			if _, ok := request.GetArguments()["minimal_output"]; !ok {
-				minimalOutput = true
-			}
 			opts := &github.SearchOptions{
 				ListOptions: github.ListOptions{
 					Page:    pagination.Page,
diff --git a/pkg/github/server.go b/pkg/github/server.go
@@ -144,6 +144,19 @@ func OptionalIntParamWithDefault(r mcp.CallToolRequest, p string, d int) (int, e
 	return v, nil
 }
 
+// OptionalBoolParamWithDefault is a helper function that can be used to fetch a requested parameter from the request
+// similar to optionalBoolParam, but it also takes a default value.
+func OptionalBoolParamWithDefault(r mcp.CallToolRequest, p string, d bool) (bool, error) {
+	v, err := OptionalParam[bool](r, p)
+	if err != nil {
+		return false, err
+	}
+	if !v {
+		return d, nil
+	}
+	return v, nil
+}
+
 // OptionalStringArrayParam is a helper function that can be used to fetch a requested parameter from the request.
 // It does the following checks:
 // 1. Checks if the parameter is present in the request, if not, it returns its zero-value
