consolidate response structs and remove unneeded message field

mattdholloway · mattdholloway · commit c82651fba16a · 2025-08-29T10:01:59.000+01:00
diff --git a/pkg/github/gists.go b/pkg/github/gists.go
@@ -259,7 +259,6 @@ func UpdateGist(getClient GetClientFn, t translations.TranslationHelperFunc) (to
 			minimalResponse := MinimalUpdateResponse{
 				URL:     updatedGist.GetHTMLURL(),
 				Updated: true,
-				Message: "Gist updated successfully",
 			}
 
 			r, err := json.Marshal(minimalResponse)
diff --git a/pkg/github/issues.go b/pkg/github/issues.go
@@ -873,7 +873,7 @@ func CreateIssue(getClient GetClientFn, t translations.TranslationHelperFunc) (t
 			}
 
 			// Return minimal response with just essential information
-			minimalResponse := MinimalIssueResponse{
+			minimalResponse := MinimalResourceResponse{
 				URL:    issue.GetHTMLURL(),
 				Number: issue.GetNumber(),
 				State:  issue.GetState(),
@@ -1254,7 +1254,6 @@ func UpdateIssue(getClient GetClientFn, t translations.TranslationHelperFunc) (t
 			minimalResponse := MinimalUpdateResponse{
 				URL:     updatedIssue.GetHTMLURL(),
 				Updated: true,
-				Message: "Issue updated successfully",
 			}
 
 			r, err := json.Marshal(minimalResponse)
diff --git a/pkg/github/issues_test.go b/pkg/github/issues_test.go
@@ -713,7 +713,7 @@ func Test_CreateIssue(t *testing.T) {
 			textContent := getTextResult(t, result)
 
 			// Unmarshal and verify the minimal result
-			var returnedIssue MinimalIssueResponse
+			var returnedIssue MinimalResourceResponse
 			err = json.Unmarshal([]byte(textContent.Text), &returnedIssue)
 			require.NoError(t, err)
 
diff --git a/pkg/github/minimal_types.go b/pkg/github/minimal_types.go
@@ -107,17 +107,8 @@ type MinimalBranch struct {
 	Protected bool   `json:"protected"`
 }
 
-// MinimalCreateResponse represents a minimal response for resource creation operations.
-type MinimalCreateResponse struct {
-	URL    string `json:"url"`
-	ID     int64  `json:"id,omitempty"`
-	Number int    `json:"number,omitempty"`
-	Name   string `json:"name,omitempty"`
-	State  string `json:"state,omitempty"`
-}
-
-// MinimalPullRequestResponse represents a minimal response for pull request operations.
-type MinimalPullRequestResponse struct {
+// MinimalResourceResponse represents a minimal response for numbered resource operations (issues, pull requests).
+type MinimalResourceResponse struct {
 	URL    string `json:"url"`
 	Number int    `json:"number"`
 	State  string `json:"state"`
@@ -132,19 +123,10 @@ type MinimalRepositoryResponse struct {
 	FullName string `json:"full_name"`
 }
 
-// MinimalIssueResponse represents a minimal response for issue operations.
-type MinimalIssueResponse struct {
-	URL    string `json:"url"`
-	Number int    `json:"number"`
-	State  string `json:"state"`
-	Title  string `json:"title,omitempty"`
-}
-
 // MinimalUpdateResponse represents a minimal response for update operations.
 type MinimalUpdateResponse struct {
 	URL     string `json:"url"`
 	Updated bool   `json:"updated"`
-	Message string `json:"message,omitempty"`
 }
 
 // MinimalGistResponse represents a minimal response for gist operations.
diff --git a/pkg/github/pullrequests.go b/pkg/github/pullrequests.go
@@ -194,7 +194,7 @@ func CreatePullRequest(getClient GetClientFn, t translations.TranslationHelperFu
 			}
 
 			// Return minimal response with just essential information
-			minimalResponse := MinimalPullRequestResponse{
+			minimalResponse := MinimalResourceResponse{
 				URL:    pr.GetHTMLURL(),
 				Number: pr.GetNumber(),
 				State:  pr.GetState(),
@@ -476,7 +476,6 @@ func UpdatePullRequest(getClient GetClientFn, getGQLClient GetGQLClientFn, t tra
 			minimalResponse := MinimalUpdateResponse{
 				URL:     finalPR.GetHTMLURL(),
 				Updated: true,
-				Message: "Pull request updated successfully",
 			}
 
 			r, err := json.Marshal(minimalResponse)
diff --git a/pkg/github/pullrequests_test.go b/pkg/github/pullrequests_test.go
@@ -1955,7 +1955,7 @@ func Test_CreatePullRequest(t *testing.T) {
 			textContent := getTextResult(t, result)
 
 			// Unmarshal and verify the minimal result
-			var returnedPR MinimalPullRequestResponse
+			var returnedPR MinimalResourceResponse
 			err = json.Unmarshal([]byte(textContent.Text), &returnedPR)
 			require.NoError(t, err)
 			assert.Equal(t, tc.expectedPR.GetNumber(), returnedPR.Number)

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,6 @@ func UpdateGist(getClient GetClientFn, t translations.TranslationHelperFunc) (to`
`259`	`259`	`minimalResponse := MinimalUpdateResponse{`
`260`	`260`	`URL: updatedGist.GetHTMLURL(),`
`261`	`261`	`Updated: true,`
`262`		`- Message: "Gist updated successfully",`
`263`	`262`	`}`
`264`	`263`
`265`	`264`	`r, err := json.Marshal(minimalResponse)`
Original file line number	Diff line number	Diff line change
`@@ -873,7 +873,7 @@ func CreateIssue(getClient GetClientFn, t translations.TranslationHelperFunc) (t`
`873`	`873`	`}`
`874`	`874`
`875`	`875`	`// Return minimal response with just essential information`
`876`		`- minimalResponse := MinimalIssueResponse{`
	`876`	`+ minimalResponse := MinimalResourceResponse{`
`877`	`877`	`URL: issue.GetHTMLURL(),`
`878`	`878`	`Number: issue.GetNumber(),`
`879`	`879`	`State: issue.GetState(),`
`@@ -1254,7 +1254,6 @@ func UpdateIssue(getClient GetClientFn, t translations.TranslationHelperFunc) (t`
`1254`	`1254`	`minimalResponse := MinimalUpdateResponse{`
`1255`	`1255`	`URL: updatedIssue.GetHTMLURL(),`
`1256`	`1256`	`Updated: true,`
`1257`		`- Message: "Issue updated successfully",`
`1258`	`1257`	`}`
`1259`	`1258`
`1260`	`1259`	`r, err := json.Marshal(minimalResponse)`
Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ func CreatePullRequest(getClient GetClientFn, t translations.TranslationHelperFu`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`// Return minimal response with just essential information`
`197`		`- minimalResponse := MinimalPullRequestResponse{`
	`197`	`+ minimalResponse := MinimalResourceResponse{`
`198`	`198`	`URL: pr.GetHTMLURL(),`
`199`	`199`	`Number: pr.GetNumber(),`
`200`	`200`	`State: pr.GetState(),`
`@@ -476,7 +476,6 @@ func UpdatePullRequest(getClient GetClientFn, getGQLClient GetGQLClientFn, t tra`
`476`	`476`	`minimalResponse := MinimalUpdateResponse{`
`477`	`477`	`URL: finalPR.GetHTMLURL(),`
`478`	`478`	`Updated: true,`
`479`		`- Message: "Pull request updated successfully",`
`480`	`479`	`}`
`481`	`480`
`482`	`481`	`r, err := json.Marshal(minimalResponse)`