more base cases

patrickshih-optimizely · patrickshih-optimizely · commit 856f3ec0e7ae · 2018-08-01T12:14:29.000-07:00
diff --git a/packages/optimizely-sdk/lib/optimizely/index.tests.js b/packages/optimizely-sdk/lib/optimizely/index.tests.js
@@ -2467,13 +2467,27 @@ describe('lib/optimizely', function() {
     });
 
     describe('#isFeatureEnabled', function() {
+      var decisionListener;
 
+      beforeEach(function(){
+        decisionListener.spy();
+      });
       it('returns false, and does not dispatch an impression event, for an invalid feature key', function() {
         var result = optlyInstance.isFeatureEnabled('thisIsDefinitelyNotAFeatureKey', 'user1');
         assert.strictEqual(result, false);
         sinon.assert.notCalled(eventDispatcher.dispatchEvent);
       });
+      it('returns false, and does not trigger listener, for an invalid feature key', function() {
+        optlyInstance.notificationCenter.addNotificationListener({
+          enums.NOTIFICATION_TYPES.FEATURE_ROLLOUT,
+          decisionListener
+        });
 
+        var result = optlyInstance.isFeatureEnabled('thisIsDefinitelyNotAFeatureKey', 'user1');
+        assert.strictEqual(result, false);
+        sinon.assert.notCalled(eventDispatcher.dispatchEvent);
+        simon.assert.notCalled(decisionListener)
+      });
       it('returns false if the instance is invalid', function() {
         optlyInstance = new Optimizely({
           clientEngine: 'node-sdk',
@@ -2492,6 +2506,29 @@ describe('lib/optimizely', function() {
         sinon.assert.calledWith(createdLogger.log, LOG_LEVEL.ERROR, 'OPTIMIZELY: Optimizely object is not valid. Failing isFeatureEnabled.');
       });
 
+      it('returns false and does not trigger listener if the instance is invalid', function() {
+        optlyInstance = new Optimizely({
+          clientEngine: 'node-sdk',
+          datafile: {
+            lasers: 300,
+            message: 'this is not a valid datafile'
+          },
+          eventBuilder: eventBuilder,
+          errorHandler: errorHandler,
+          eventDispatcher: eventDispatcher,
+          jsonSchemaValidator: jsonSchemaValidator,
+          logger: createdLogger,
+        });
+        optlyInstance.notificationCenter.addNotificationListener({
+          enums.NOTIFICATION_TYPES.FEATURE_ROLLOUT,
+          decisionListener
+        });
+        var result = optlyInstance.isFeatureEnabled('test_feature_for_experiment', 'user1');
+        assert.strictEqual(result, false);
+        sinon.assert.calledWith(createdLogger.log, LOG_LEVEL.ERROR, 'OPTIMIZELY: Optimizely object is not valid. Failing isFeatureEnabled.');
+        simon.assert.notCalled(decisionListener)
+      });
+
       describe('when the user bucketed into a variation of an experiment with the feature', function() {
         var attributes = { test_attribute: 'test_value' };
 
@@ -2771,12 +2808,6 @@ describe('lib/optimizely', function() {
       });
 
       describe('user bucketed into a variation of a rollout of the feature', function() {
-        var decisionListener;
-
-        beforeEach(function(){
-          decisionListener.spy();
-        });
-
         describe('when the variation is toggled ON', function() {
           beforeEach(function() {
             // This experiment is the first audience targeting rule in the rollout of feature 'test_feature'
@@ -2816,17 +2847,6 @@ describe('lib/optimizely', function() {
         });
 
         describe('when the variation is toggled OFF', function() {
-          beforeEach(function() {
-            // This experiment is the second audience targeting rule in the rollout of feature 'test_feature'
-            var experiment = optlyInstance.configObj.experimentKeyMap['594037'];
-            var variation = experiment.variations[0];
-            sandbox.stub(optlyInstance.decisionService, 'getVariationForFeature').returns({
-              experiment: experiment,
-              variation: variation,
-              decisionSource: DECISION_SOURCES.ROLLOUT,
-            });
-          });
-
           it('returns false ', function() {
             var result = optlyInstance.isFeatureEnabled('test_feature', 'user1', {
               test_attribute: 'test_value',
@@ -2870,7 +2890,7 @@ describe('lib/optimizely', function() {
         });
 
 
-        it('returns false and does not dispatch an event and notification listener is not triggered', function() {
+        it('returns false and does not dispatch an event, and a notification listener is not triggered', function() {
           optlyInstance.notificationCenter.addNotificationListener({
             enums.NOTIFICATION_TYPES.FEATURE_ROLLOUT,
             decisionListener
