replaced lodash keyby

zashraf1985 · zashraf1985 · commit 986bd351c6f6 · 2020-02-18T14:17:01.000-08:00
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.js b/packages/optimizely-sdk/lib/utils/fns/index.js
@@ -15,6 +15,7 @@
  */
 var uuid = require('uuid');
 var _isFinite = require('lodash/isFinite');
+var { keyBy } = require('@optimizely/js-sdk-utils');
 var MAX_NUMBER_LIMIT = Math.pow(2, 53);
 
 module.exports = {
@@ -29,7 +30,15 @@ module.exports = {
   isFinite: function(number) {
     return _isFinite(number) && Math.abs(number) <= MAX_NUMBER_LIMIT;
   },
-  keyBy: require('lodash/keyBy'),
+  keyBy: function(arr, callback) {
+    if (!arr) return {};
+    if (typeof callback === 'string' || callback instanceof String) {
+      return keyBy(arr, function(item) {
+        return item[callback];
+      });
+    }
+    return keyBy(arr, callback);
+  },
   filter: require('lodash/filter'),
   forEach: require('lodash/forEach'),
   forOwn: require('lodash/forOwn'),
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.tests.js b/packages/optimizely-sdk/lib/utils/fns/index.tests.js
@@ -37,5 +37,52 @@ describe('lib/utils/fns', function() {
         assert.isTrue(fns.isFinite(-Math.pow(2, 53)));
       });
     });
+    describe('keyBy', function() {
+      it('should return correct object if callback is a function', function() {
+        var arr = [
+          { key1: 'row1', key2: 'key2row1' },
+          { key1: 'row2', key2: 'key2row2' },
+          { key1: 'row3', key2: 'key2row3' },
+          { key1: 'row4', key2: 'key2row4' },
+        ];
+
+        var obj = fns.keyBy(arr, function(item) {
+          return item['key1'];
+        });
+
+        assert.deepEqual(obj, {
+          row1: { key1: 'row1', key2: 'key2row1' },
+          row2: { key1: 'row2', key2: 'key2row2' },
+          row3: { key1: 'row3', key2: 'key2row3' },
+          row4: { key1: 'row4', key2: 'key2row4' }
+        });
+      });
+
+      it('should return correct object if callback is a string key', function() {
+        var arr = [
+          { key1: 'row1', key2: 'key2row1' },
+          { key1: 'row2', key2: 'key2row2' },
+          { key1: 'row3', key2: 'key2row3' },
+          { key1: 'row4', key2: 'key2row4' },
+        ];
+
+        var obj = fns.keyBy(arr, 'key1');
+
+        assert.deepEqual(obj, {
+          row1: { key1: 'row1', key2: 'key2row1' },
+          row2: { key1: 'row2', key2: 'key2row2' },
+          row3: { key1: 'row3', key2: 'key2row3' },
+          row4: { key1: 'row4', key2: 'key2row4' }
+        });
+      });
+
+      it('should return empty object when first argument is null or undefined', function() {
+        var obj = fns.keyBy(null, 'key1');
+        assert.isEmpty(obj);
+
+        obj = fns.keyBy(undefined, 'key1');
+        assert.isEmpty(obj);
+      });
+    });
   });
-});
+});
