Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit b3d1077

Browse files
authored
Merge branch 'master' into zeeshan/replace-lodash-keyby
2 parents f41ca07 + 653296d commit b3d1077

File tree

8 files changed

+18
-26
lines changed

8 files changed

+18
-26
lines changed

packages/optimizely-sdk/CHANGELOG.MD

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
55
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
8+
9+
## [3.5.0] - February 20th, 2020
10+
811
### Bug fixes
912
- Fixed default event dispatcher not used in React Native entry point ([#383](https://github.com/optimizely/javascript-sdk/pull/383))
13+
- Fixed errors in `getOptimizelyConfig` TypeScript type definitions ([#406](https://github.com/optimizely/javascript-sdk/pull/406))
1014

1115
### New Features
1216
- Promise returned from `close` tracks the state of in-flight event dispatcher requests ([#404](https://github.com/optimizely/javascript-sdk/pull/404))

packages/optimizely-sdk/lib/index.browser.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ describe('javascript-sdk', function() {
148148
optlyInstance.onReady().catch(function() {});
149149

150150
assert.instanceOf(optlyInstance, Optimizely);
151-
assert.equal(optlyInstance.clientVersion, '3.4.1');
151+
assert.equal(optlyInstance.clientVersion, '3.5.0');
152152
});
153153

154154
it('should set the JavaScript client engine and version', function() {

packages/optimizely-sdk/lib/index.d.ts

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ declare module "@optimizely/optimizely-sdk" {
115115
onReady(options?: {
116116
timeout?: number;
117117
}): Promise<{ success: boolean; reason?: string }>;
118-
close(): void;
118+
close(): void;
119119
}
120120

121121
// An event to be submitted to Optimizely, enabling tracking the reach and impact of
@@ -225,53 +225,41 @@ declare module "@optimizely/optimizely-sdk" {
225225
type: string;
226226
value: string;
227227
}
228-
228+
229229
export interface OptimizelyVariation {
230230
id: string;
231231
key: string;
232232
featureEnabled?: boolean;
233233
variablesMap: {
234-
[variableKey: string]: {
235-
variable: OptimizelyVariable;
236-
};
234+
[variableKey: string]: OptimizelyVariable;
237235
};
238236
}
239237

240238
export interface OptimizelyExperiment {
241239
id: string;
242240
key: string;
243241
variationsMap: {
244-
[variationKey: string]: {
245-
variation: OptimizelyVariation;
246-
};
242+
[variationKey: string]: OptimizelyVariation;
247243
};
248244
}
249245

250246
export interface OptimizelyFeature {
251247
id: string;
252248
key: string;
253249
experimentsMap: {
254-
[experimentKey: string]: {
255-
experiment: OptimizelyExperiment;
256-
};
250+
[experimentKey: string]: OptimizelyExperiment;
257251
};
258252
variablesMap: {
259-
[variableKey: string]: {
260-
variable: OptimizelyVariable;
261-
};
253+
[variableKey: string]: OptimizelyVariable;
262254
};
263255
}
264256

265257
export interface OptimizelyConfig {
266258
experimentsMap: {
267-
[experimentKey: string]: {
268-
experiment: OptimizelyExperiment;
269-
};
259+
[experimentKey: string]: OptimizelyExperiment;
270260
};
271261
featuresMap: {
272-
[featureKey: string]: {
273-
feature: OptimizelyFeature;
274-
};
262+
[featureKey: string]: OptimizelyFeature;
275263
};
276264
revision: string;
277265
}

packages/optimizely-sdk/lib/index.node.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe('optimizelyFactory', function() {
9292
optlyInstance.onReady().catch(function() {});
9393

9494
assert.instanceOf(optlyInstance, Optimizely);
95-
assert.equal(optlyInstance.clientVersion, '3.4.1');
95+
assert.equal(optlyInstance.clientVersion, '3.5.0');
9696
});
9797

9898
describe('event processor configuration', function() {

packages/optimizely-sdk/lib/index.react_native.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe('javascript-sdk/react-native', function() {
9292
optlyInstance.onReady().catch(function() {});
9393

9494
assert.instanceOf(optlyInstance, Optimizely);
95-
assert.equal(optlyInstance.clientVersion, '3.4.1');
95+
assert.equal(optlyInstance.clientVersion, '3.5.0');
9696
});
9797

9898
it('should set the JavaScript client engine and version', function() {

packages/optimizely-sdk/lib/utils/enums/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ exports.CONTROL_ATTRIBUTES = {
159159
exports.JAVASCRIPT_CLIENT_ENGINE = 'javascript-sdk';
160160
exports.NODE_CLIENT_ENGINE = 'node-sdk';
161161
exports.REACT_CLIENT_ENGINE = 'react-sdk';
162-
exports.NODE_CLIENT_VERSION = '3.4.1';
162+
exports.NODE_CLIENT_VERSION = '3.5.0';
163163

164164
exports.VALID_CLIENT_ENGINES = [
165165
exports.NODE_CLIENT_ENGINE,

packages/optimizely-sdk/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/optimizely-sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@optimizely/optimizely-sdk",
3-
"version": "3.4.1",
3+
"version": "3.5.0",
44
"description": "JavaScript SDK for Optimizely X Full Stack",
55
"main": "lib/index.node.js",
66
"browser": "lib/index.browser.js",

0 commit comments

Comments
 (0)