Replace forEach & push with map

elenatanasoiu · elenatanasoiu · commit b95f6a5afb81 · 2022-09-28T15:54:27.000+01:00
diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-processor.ts
@@ -60,11 +60,8 @@ export function processVariantAnalysis(
 function processScannedRepositories(
   scannedRepos: ApiVariantAnalysisScannedRepository[]
 ): VariantAnalysisScannedRepository[] {
-
-  const result: VariantAnalysisScannedRepository[] = [];
-
-  scannedRepos.forEach(function(scannedRepo) {
-    const parsedRepo: VariantAnalysisScannedRepository = {
+  return scannedRepos.map(scannedRepo => {
+    return {
       repository: {
         id: scannedRepo.repository.id,
         fullName: scannedRepo.repository.full_name,
@@ -75,11 +72,7 @@ function processScannedRepositories(
       artifactSizeInBytes: scannedRepo.artifact_size_in_bytes,
       failureMessage: scannedRepo.failure_message
     };
-
-    result.push(parsedRepo);
   });
-
-  return result;
 }
 
 function processSkippedRepositories(
@@ -154,4 +147,4 @@ export function processFailureReason(failureReason: ApiVariantAnalysisFailureRea
     case 'internal_error':
       return VariantAnalysisFailureReason.InternalError;
   }
-}
+}
