Not react to first-green-build and invite-users actions on BB projects

appplemac · appplemac · commit 4f37c72f6bf1 · 2016-06-20T11:10:59.000+02:00
diff --git a/src-cljs/frontend/controllers/controls.cljs b/src-cljs/frontend/controllers/controls.cljs
@@ -849,32 +849,35 @@
 
 (defmethod post-control-event! :load-first-green-build-github-users
   [target message {:keys [vcs-type project-name]} previous-state current-state]
-  (ajax/ajax :get
-             (api-path/project-users vcs-type project-name)
-             :first-green-build-github-users
-             (get-in current-state [:comms :api])
-             :context {:project-name project-name}))
+  (if (or (nil? vcs-type) (= "github" vcs-type))
+    (ajax/ajax :get
+               (api-path/project-users vcs-type project-name)
+               :first-green-build-github-users
+               (get-in current-state [:comms :api])
+               :context {:project-name project-name})))
 
 (defmethod post-control-event! :invited-github-users
   [target message {:keys [vcs-type project-name org-name invitees]} previous-state current-state]
-  (let [org-vcs-type "github"
-        context (if project-name
-                  ;; TODO: non-hackish way to indicate the type of invite
-                  {:project project-name :first_green_build true}
-                  {:org org-name})]
-    (button-ajax :post
-                 (if project-name
-                   (api-path/project-users-invite vcs-type project-name)
-                   (api-path/organization-invite org-vcs-type org-name))
-                 :invite-github-users
-                 (get-in current-state [:comms :api])
-                 :context context
-                 :params invitees
-                 :events {:success #(analytics/track {:event-type :teammates-invited
-                                                      :current-state current-state
-                                                      :properties {:vcs-type :github
-                                                                   :invitees invitees
-                                                                   :invitee-count (count invitees)}})})))
+  (if (or (nil? vcs-type) (= "github" vcs-type))
+    (let [project-vcs-type (or vcs-type "github")
+          org-vcs-type "github"
+          context (if project-name
+                    ;; TODO: non-hackish way to indicate the type of invite
+                    {:project project-name :first_green_build true}
+                    {:org org-name})]
+      (button-ajax :post
+                   (if project-name
+                     (api-path/project-users-invite project-vcs-type project-name)
+                     (api-path/organization-invite org-vcs-type org-name))
+                   :invite-github-users
+                   (get-in current-state [:comms :api])
+                   :context context
+                   :params invitees
+                   :events {:success #(analytics/track {:event-type :teammates-invited
+                                                        :current-state current-state
+                                                        :properties {:vcs-type :github
+                                                                     :invitees invitees
+                                                                     :invitee-count (count invitees)}})}))))
 
 (defmethod post-control-event! :report-build-clicked
   [target message {:keys [build-url]} previous-state current-state]
diff --git a/test-cljs/frontend/controllers/controls_test.cljs b/test-cljs/frontend/controllers/controls_test.cljs
@@ -4,6 +4,7 @@
             [frontend.state :as state]
             [frontend.utils.ajax :as ajax]
             [frontend.analytics.core :as analytics]
+            [frontend.api.path :as api-path]
             [frontend.controllers.controls :as controls]
             [bond.james :as bond :include-macros true]
             [goog.string :as gstring])
@@ -207,6 +208,7 @@
 (deftest post-control-event-invited-github-users-works
   (let [calls (atom [])
         project-name "proj"
+        vcs-type "github"
         invitees ["me@foo.com", "you@bar.co"]
         control-data {:project-name project-name
                       :org-name "org"
@@ -221,9 +223,28 @@
               args (-> calls first :args)]
           (is (= (count calls) 1))
           (is (= (nth args 0) :post))
-          (is (= (nth args 1) (gstring/format "/api/v1/project/%s/users/invite" project-name)))
+          (is (= (nth args 1) (api-path/project-users-invite vcs-type project-name)))
           (is (= (nth args 2) :invite-github-users))
           (is (= (nth args 3) api-ch))
           (is (= (->> (nth args 4) (apply hash-map) :context) {:project project-name
                                                               :first_green_build true}))
           (is (= (->> (nth args 4) (apply hash-map) :params) invitees)))))))
+
+(deftest post-control-event-invited-github-users-does-nothing-for-bb-projects
+  (let [calls (atom [])
+        project-name "proj"
+        vcs-type "bitbucket"
+        invitees ["me@foo.com", "you@bar.co"]
+        control-data {:project-name project-name
+                      :vcs-type vcs-type
+                      :org-name "org"
+                      :invitees ["me@foo.com", "you@bar.co"]}
+        api-ch "api-ch"
+        current-state {:comms {:api api-ch}}]
+    (testing "the post-control-event invite-github-users does nothing for bitbucket projects"
+      (with-redefs [controls/button-ajax (fn [method url message channel & opts]
+                                           (swap! calls conj {:args (list method url message channel opts)}))]
+        (controls/post-control-event! {} :invited-github-users control-data {} current-state)
+        (let [calls @calls
+              args (-> calls first :args)]
+          (is (= (count calls) 0)))))))
