Stabilizes CarrierMovementTest#testSameValueAsEqualsHashCode

Danil · Danil · commit 305db83f6e6b · 2018-06-03T09:27:04.000-04:00
The default constructor of java.util.Date depends on the
system clock.  If the clock should happen to tick while the
CarrierMovements in this test are initialized, two
movements we expect to be the same will be off by a millisecond.
diff --git a/src/test/java/se/citerus/dddsample/domain/model/voyage/CarrierMovementTest.java b/src/test/java/se/citerus/dddsample/domain/model/voyage/CarrierMovementTest.java
@@ -29,10 +29,16 @@ public void testConstructor() {
 
   @Test
   public void testSameValueAsEqualsHashCode() {
-    CarrierMovement cm1 = new CarrierMovement(STOCKHOLM, HAMBURG, new Date(), new Date());
-    CarrierMovement cm2 = new CarrierMovement(STOCKHOLM, HAMBURG, new Date(), new Date());
-    CarrierMovement cm3 = new CarrierMovement(HAMBURG, STOCKHOLM, new Date(), new Date());
-    CarrierMovement cm4 = new CarrierMovement(HAMBURG, STOCKHOLM, new Date(), new Date());
+    long referenceTime = System.currentTimeMillis();
+
+    // One could, in theory, use the same Date(referenceTime) for all of these movements
+    // However, in practice, carrier movements will be initialized by different processes
+    // so we might have different Date that reference the same time, and we want to be
+    // certain that sameValueAs does the right thing in that case.
+    CarrierMovement cm1 = new CarrierMovement(STOCKHOLM, HAMBURG, new Date(referenceTime), new Date(referenceTime));
+    CarrierMovement cm2 = new CarrierMovement(STOCKHOLM, HAMBURG, new Date(referenceTime), new Date(referenceTime));
+    CarrierMovement cm3 = new CarrierMovement(HAMBURG, STOCKHOLM, new Date(referenceTime), new Date(referenceTime));
+    CarrierMovement cm4 = new CarrierMovement(HAMBURG, STOCKHOLM, new Date(referenceTime), new Date(referenceTime));
 
     assertThat(cm1.sameValueAs(cm2)).isTrue();
     assertThat(cm2.sameValueAs(cm3)).isFalse();
