Renamed CargoService.notify() to inspectCargo(), which better reflects what actually happens

peterbacklund · peterbacklund · commit b3350cd3eaf4 · 2008-08-27T18:29:08.000Z
diff --git a/dddsample/src/main/java/se/citerus/dddsample/application/messaging/HandlingEventMessageDelegate.java b/dddsample/src/main/java/se/citerus/dddsample/application/messaging/HandlingEventMessageDelegate.java
@@ -28,7 +28,7 @@ public void onMessage(final Message message) {
     }
     try {
       String tidString = message.getStringProperty(JmsDomainEventNotifierImpl.TRACKING_ID_KEY);
-      trackingService.notify(new TrackingId(tidString));
+      trackingService.inspectCargo(new TrackingId(tidString));
     } catch (JMSException e) {
       logger.error(e, e);
     }
diff --git a/dddsample/src/main/java/se/citerus/dddsample/application/messaging/ThreadBasedDomainEventNotifierImpl.java b/dddsample/src/main/java/se/citerus/dddsample/application/messaging/ThreadBasedDomainEventNotifierImpl.java
@@ -14,7 +14,7 @@ public class ThreadBasedDomainEventNotifierImpl implements DomainEventNotifier {
   public void cargoWasHandled(final HandlingEvent event) {
     new Thread(new Runnable() {
       public void run() {
-        trackingService.notify(event.cargo().trackingId());
+        trackingService.inspectCargo(event.cargo().trackingId());
       }
     }).start();
   }
diff --git a/dddsample/src/main/java/se/citerus/dddsample/domain/service/TrackingService.java b/dddsample/src/main/java/se/citerus/dddsample/domain/service/TrackingService.java
@@ -18,12 +18,12 @@ public interface TrackingService {
   Cargo track(TrackingId trackingId);
 
   /**
-   * Send relevant notifications to interested parties,
+   * Inspect cargo and send relevant notifications to interested parties,
    * for example if a cargo has been misdirected, or unloaded
    * at the final destination.
    *
    * @param trackingId cargo tracking id
    */
-  void notify(TrackingId trackingId);
+  void inspectCargo(TrackingId trackingId);
 
 }
diff --git a/dddsample/src/main/java/se/citerus/dddsample/domain/service/impl/TrackingServiceImpl.java b/dddsample/src/main/java/se/citerus/dddsample/domain/service/impl/TrackingServiceImpl.java
@@ -23,7 +23,7 @@ public Cargo track(final TrackingId trackingId) {
   }
 
   @Transactional(readOnly = true)
-  public void notify(final TrackingId trackingId) {
+  public void inspectCargo(final TrackingId trackingId) {
     Validate.notNull(trackingId);
 
     final Cargo cargo = cargoRepository.find(trackingId);

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public void onMessage(final Message message) {`
`28`	`28`	`}`
`29`	`29`	`try {`
`30`	`30`	`String tidString = message.getStringProperty(JmsDomainEventNotifierImpl.TRACKING_ID_KEY);`
`31`		`- trackingService.notify(new TrackingId(tidString));`
	`31`	`+ trackingService.inspectCargo(new TrackingId(tidString));`
`32`	`32`	`} catch (JMSException e) {`
`33`	`33`	`logger.error(e, e);`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public class ThreadBasedDomainEventNotifierImpl implements DomainEventNotifier {`
`14`	`14`	`public void cargoWasHandled(final HandlingEvent event) {`
`15`	`15`	`new Thread(new Runnable() {`
`16`	`16`	`public void run() {`
`17`		`- trackingService.notify(event.cargo().trackingId());`
	`17`	`+ trackingService.inspectCargo(event.cargo().trackingId());`
`18`	`18`	`}`
`19`	`19`	`}).start();`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,12 +18,12 @@ public interface TrackingService {`
`18`	`18`	`Cargo track(TrackingId trackingId);`
`19`	`19`
`20`	`20`	`/**`
`21`		`- * Send relevant notifications to interested parties,`
	`21`	`+ * Inspect cargo and send relevant notifications to interested parties,`
`22`	`22`	`* for example if a cargo has been misdirected, or unloaded`
`23`	`23`	`* at the final destination.`
`24`	`24`	`*`
`25`	`25`	`* @param trackingId cargo tracking id`
`26`	`26`	`*/`
`27`		`- void notify(TrackingId trackingId);`
	`27`	`+ void inspectCargo(TrackingId trackingId);`
`28`	`28`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public Cargo track(final TrackingId trackingId) {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`@Transactional(readOnly = true)`
`26`		`- public void notify(final TrackingId trackingId) {`
	`26`	`+ public void inspectCargo(final TrackingId trackingId) {`
`27`	`27`	`Validate.notNull(trackingId);`
`28`	`28`
`29`	`29`	`final Cargo cargo = cargoRepository.find(trackingId);`