Skip to content

Commit cb73e35

Browse files
committed
Removed unchecked exception from signature
1 parent f7d3e11 commit cb73e35

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/application/handling/HandlingEventService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package se.citerus.dddsample.tracking.core.application.handling;
22

33
import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
4-
import se.citerus.dddsample.tracking.core.domain.model.handling.CannotCreateHandlingEventException;
54
import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
65
import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
76
import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
@@ -33,6 +32,6 @@ void registerHandlingEvent(Date completionTime,
3332
VoyageNumber voyageNumber,
3433
UnLocode unLocode,
3534
HandlingActivityType type,
36-
OperatorCode operatorCode) throws CannotCreateHandlingEventException;
35+
OperatorCode operatorCode);
3736

3837
}

dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/application/handling/HandlingEventServiceImpl.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77
import org.springframework.transaction.annotation.Transactional;
88
import se.citerus.dddsample.tracking.core.application.event.SystemEvents;
99
import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
10-
import se.citerus.dddsample.tracking.core.domain.model.handling.*;
10+
import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEvent;
11+
import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEventFactory;
12+
import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEventRepository;
13+
import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
1114
import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
1215
import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
1316
import se.citerus.dddsample.tracking.core.domain.model.voyage.VoyageNumber;
@@ -20,7 +23,8 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
2023
private final SystemEvents systemEvents;
2124
private final HandlingEventRepository handlingEventRepository;
2225
private final HandlingEventFactory handlingEventFactory;
23-
private final Log logger = LogFactory.getLog(HandlingEventServiceImpl.class);
26+
27+
private static final Log LOG = LogFactory.getLog(HandlingEventServiceImpl.class);
2428

2529
@Autowired
2630
public HandlingEventServiceImpl(final HandlingEventRepository handlingEventRepository,
@@ -35,7 +39,7 @@ public HandlingEventServiceImpl(final HandlingEventRepository handlingEventRepos
3539
@Transactional
3640
public void registerHandlingEvent(final Date completionTime, final TrackingId trackingId,
3741
final VoyageNumber voyageNumber, final UnLocode unLocode,
38-
final HandlingActivityType type, final OperatorCode operatorCode) throws CannotCreateHandlingEventException {
42+
final HandlingActivityType type, final OperatorCode operatorCode) {
3943

4044
/* Using a factory to create a HandlingEvent (aggregate). This is where
4145
it is determined wether the incoming data, the attempt, actually is capable
@@ -53,7 +57,7 @@ state of the handling handlingEvent aggregate (but not the cargo aggregate -
5357
/* Publish a system event */
5458
systemEvents.notifyOfHandlingEvent(handlingEvent);
5559

56-
logger.info("Registered handling event: " + handlingEvent);
60+
LOG.info("Registered handling event: " + handlingEvent);
5761
}
5862

5963
}

0 commit comments

Comments
 (0)