Skip to content

Commit f6417be

Browse files
committed
Null check, removed unused methods.
1 parent 0969532 commit f6417be

File tree

2 files changed

+4
-16
lines changed
  • dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/domain/model/cargo

2 files changed

+4
-16
lines changed

dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/domain/model/cargo/Cargo.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,10 @@ public Location earliestReroutingLocation() {
262262
* that describes a continuous route even if the cargo is currently misdirected.
263263
*/
264264
public Itinerary itineraryMergedWith(final Itinerary other) {
265+
if (this.itinerary == null) {
266+
return other;
267+
}
268+
265269
if (isMisdirected() && transportStatus() == ONBOARD_CARRIER) {
266270
final Leg currentLeg = Leg.deriveLeg(
267271
currentVoyage(), lastKnownLocation(), currentVoyage().arrivalLocationAfterDepartureFrom(lastKnownLocation())

dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/domain/model/cargo/Leg.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -115,22 +115,6 @@ boolean matchesActivity(final HandlingActivity handlingActivity) {
115115
return false;
116116
}
117117

118-
Leg ifLoadLocationSameAs(final HandlingActivity handlingActivity) {
119-
if (loadLocation.sameAs(handlingActivity.location())) {
120-
return this;
121-
} else {
122-
return null;
123-
}
124-
}
125-
126-
Leg ifUnloadLocationSameAs(final HandlingActivity handlingActivity) {
127-
if (unloadLocation.sameAs(handlingActivity.location())) {
128-
return this;
129-
} else {
130-
return null;
131-
}
132-
}
133-
134118
HandlingActivity deriveLoadActivity() {
135119
return loadOnto(voyage).in(loadLocation);
136120
}

0 commit comments

Comments
 (0)