[FIX] core: possibility of allocation error in native magic libraries

xmo-odoo · xmo-odoo · commit 15620475529f · 2022-01-21T15:56:41.000Z
Both of the native `magic` libraries can trigger an allocation error if the buffer being sniffed is large. This results in nothing useful for the user and just triggers and exception when trying to create large attachments (in the hundreds of MBs). Fix by implementing the workaround suggested in ahupp/python-magic#82, under the assumption that it should also work fine for Debian's python-magic. The pure-python trivial version of odoo should not have this issue, as it does not normally copy the source buffer in full, it just seeks and slices the buffer, and occasionally parses it as a zip (but does not normally load everything in memory). Task-2722110 closes odoo#83180 X-original-commit: 94fc664 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
diff --git a/odoo/tools/mimetypes.py b/odoo/tools/mimetypes.py
@@ -180,7 +180,7 @@ def _odoo_guess_mimetype(bin_data, default='application/octet-stream'):
         _guesser = ms.buffer
 
     def guess_mimetype(bin_data, default=None):
-        mimetype = _guesser(bin_data)
+        mimetype = _guesser(bin_data[:1024])
         # upgrade incorrect mimetype to official one, fixed upstream
         # https://github.com/file/file/commit/1a08bb5c235700ba623ffa6f3c95938fe295b262
         if mimetype == 'image/svg':
