[FIX] mrp: mass produce should fill qty_done

amoyaux · amoyaux · commit 8ce5926b5a33 · 2022-01-20T12:42:56.000Z
Usecase: - Create a BoM with a product tracked by SN - Create a MO with qty 5 - Mass produce - Generate -> All the `stock.move.line` in the move_raw_ids don't have the qty done prefilled. The purpose of the feature is to create and validate a lot of MO at once. Which is impossible if you have to fill all the quantity manualy. The choice of a new kwargs that directly set the qty_done is justified by the performance. -> For On a BoM with 10 components for a final product. For 1000 finished product with SN - If we do a loop on each `stock.move.line` to set qty_done as the reserved quantity. It goes from 40s to 135s - With the kwargs. It remaines 40s closes odoo#82996 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
diff --git a/addons/mrp/models/mrp_production.py b/addons/mrp/models/mrp_production.py
@@ -1525,7 +1525,7 @@ def _generate_backorder_productions(self, close_mo=True):
                 wo.qty_producing = wo.qty_remaining
         return backorders
 
-    def _split_productions(self, amounts=False, cancel_remaning_qty=False):
+    def _split_productions(self, amounts=False, cancel_remaning_qty=False, set_consumed_qty=False):
         """ Splits productions into productions smaller quantities to produce, i.e. creates
         its backorders.
         :param dict amounts: a dict with a production as key and a list value containing
@@ -1650,12 +1650,17 @@ def _default_amounts(production):
                     taken_qty_uom = product_uom._compute_quantity(taken_qty, move_line.product_uom_id)
                     if move == initial_move:
                         move_line.with_context(bypass_reservation_update=True).product_uom_qty = taken_qty_uom
+                        if set_consumed_qty:
+                            move_line.qty_done = taken_qty_uom
                     elif not float_is_zero(taken_qty_uom, precision_rounding=move_line.product_uom_id.rounding):
-                        move_lines_vals.append(dict(
+                        new_ml_vals = dict(
                             ml_vals,
                             product_uom_qty=taken_qty_uom,
                             move_id=move.id
-                        ))
+                        )
+                        if set_consumed_qty:
+                            new_ml_vals['qty_done'] = taken_qty_uom
+                        move_lines_vals.append(new_ml_vals)
                     quantity -= taken_qty
                     move_qty_to_reserve -= taken_qty
 
diff --git a/addons/mrp/wizard/stock_assign_serial_numbers.py b/addons/mrp/wizard/stock_assign_serial_numbers.py
@@ -57,11 +57,11 @@ def _onchange_serial_numbers(self):
         self.produced_qty = len(serial_numbers)
         self.show_apply = self.produced_qty == self.expected_qty
         self.show_backorders = self.produced_qty > 0 and self.produced_qty < self.expected_qty
-    
+
     def _assign_serial_numbers(self, cancel_remaining_quantity=False):
         serial_numbers = self._get_serial_numbers()
         productions = self.production_id._split_productions(
-            {self.production_id: [1] * len(serial_numbers)}, cancel_remaining_quantity)
+            {self.production_id: [1] * len(serial_numbers)}, cancel_remaining_quantity, set_consumed_qty=True)
         production_lots_vals = []
         for serial_name in serial_numbers:
             production_lots_vals.append({
@@ -76,6 +76,10 @@ def _assign_serial_numbers(self, cancel_remaining_quantity=False):
             for workorder in production.workorder_ids:
                 workorder.qty_produced = workorder.qty_producing
 
+        if productions and len(production_lots) < len(productions):
+            productions[-1].move_raw_ids.move_line_ids.write({'qty_done': 0})
+            productions[-1].state = "confirmed"
+
     def apply(self):
         self._assign_serial_numbers()
 
