Polish WebSocketIntegrationTests

rstoyanchev · rstoyanchev · commit de1eb343e7f7 · 2018-05-01T14:26:44.000-04:00
diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/ReactorNettyWebSocketSession.java b/spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/ReactorNettyWebSocketSession.java
@@ -20,7 +20,6 @@
 import org.reactivestreams.Publisher;
 import reactor.core.publisher.Flux;
 import reactor.core.publisher.Mono;
-import reactor.core.publisher.MonoProcessor;
 import reactor.ipc.netty.NettyInbound;
 import reactor.ipc.netty.NettyOutbound;
 import reactor.ipc.netty.NettyPipeline;
@@ -35,17 +34,15 @@
 
 
 /**
- * Spring {@link WebSocketSession} implementation that adapts to Reactor Netty's
- * WebSocket {@link NettyInbound} and {@link NettyOutbound}.
+ * {@link WebSocketSession} implementation for use with the Reactor Netty's
+ * {@link NettyInbound} and {@link NettyOutbound}.
  *
  * @author Rossen Stoyanchev
  * @since 5.0
  */
 public class ReactorNettyWebSocketSession
 		extends NettyWebSocketSessionSupport<ReactorNettyWebSocketSession.WebSocketConnection> {
 
-	private final MonoProcessor<WebSocketFrame> closeMono = MonoProcessor.create();
-
 
 	public ReactorNettyWebSocketSession(WebsocketInbound inbound, WebsocketOutbound outbound,
 			HandshakeInfo info, NettyDataBufferFactory bufferFactory) {
diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/socket/WebSocketIntegrationTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/socket/WebSocketIntegrationTests.java
@@ -43,13 +43,14 @@
 
 /**
  * Integration tests with server-side {@link WebSocketHandler}s.
- *
  * @author Rossen Stoyanchev
  */
 public class WebSocketIntegrationTests extends AbstractWebSocketIntegrationTests {
 
 	private static final Log logger = LogFactory.getLog(WebSocketIntegrationTests.class);
 
+	private static final Duration TIMEOUT = Duration.ofMillis(5000);
+
 
 	@Override
 	protected Class<?> getWebConfigClass() {
@@ -71,14 +72,12 @@ public void echo() throws Exception {
 							.thenMany(session.receive().take(count).map(WebSocketMessage::getPayloadAsText))
 							.subscribeWith(output)
 							.doOnNext(s -> logger.debug("inbound " + s))
-							.then()
-							.doOnSuccessOrError((aVoid, ex) ->
-									logger.debug("Done with " + (ex != null ? ex.getMessage() : "success")));
+							.then();
 				})
-				.block(Duration.ofMillis(5000));
+				.doOnSuccessOrError((aVoid, ex) -> logger.debug("Done: " + (ex != null ? ex.getMessage() : "success")))
+				.block(TIMEOUT);
 
-		assertEquals(input.collectList().block(Duration.ofMillis(5000)),
-				output.collectList().block(Duration.ofMillis(5000)));
+		assertEquals(input.collectList().block(TIMEOUT), output.collectList().block(TIMEOUT));
 	}
 
 	@Test
@@ -102,13 +101,13 @@ public Mono<Void> handle(WebSocketSession session) {
 								.then();
 					}
 				})
-				.block(Duration.ofMillis(5000));
+				.block(TIMEOUT);
 
 		HandshakeInfo info = infoRef.get();
 		assertThat(info.getHeaders().getFirst("Upgrade"), Matchers.equalToIgnoringCase("websocket"));
 		assertEquals(protocol, info.getHeaders().getFirst("Sec-WebSocket-Protocol"));
 		assertEquals("Wrong protocol accepted", protocol, info.getSubProtocol());
-		assertEquals("Wrong protocol detected on the server side", protocol, output.block(Duration.ofMillis(5000)));
+		assertEquals("Wrong protocol detected on the server side", protocol, output.block(TIMEOUT));
 	}
 
 	@Test
@@ -122,9 +121,9 @@ public void customHeader() throws Exception {
 						.map(WebSocketMessage::getPayloadAsText)
 						.subscribeWith(output)
 						.then())
-				.block(Duration.ofMillis(5000));
+				.block(TIMEOUT);
 
-		assertEquals("my-header:my-value", output.block(Duration.ofMillis(5000)));
+		assertEquals("my-header:my-value", output.block(TIMEOUT));
 	}
 
 	@Test
@@ -139,7 +138,7 @@ public void sessionClosing() throws Exception {
 								logger.debug("Completed with: " + signalType);
 							});
 				})
-				.block(Duration.ofMillis(5000));
+				.block(TIMEOUT);
 	}
 
 
