Skip to content

Commit bcc972d

Browse files
author
masensio
committed
OC-2459: Ask for pincode, when click on an instant upload notification
1 parent 72f6313 commit bcc972d

File tree

5 files changed

+119
-80
lines changed

5 files changed

+119
-80
lines changed

src/com/owncloud/android/files/services/FileUploader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,7 @@ private void notifyUploadResult(RemoteOperationResult uploadResult, UploadFileOp
787787
}
788788
showDetailsIntent.putExtra(FileActivity.EXTRA_FILE, upload.getFile());
789789
showDetailsIntent.putExtra(FileActivity.EXTRA_ACCOUNT, upload.getAccount());
790+
showDetailsIntent.putExtra(FileActivity.EXTRA_FROM_NOTIFICATION, true);
790791
showDetailsIntent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
791792
mNotification.contentIntent = PendingIntent.getActivity(getApplicationContext(),
792793
(int) System.currentTimeMillis(), showDetailsIntent, 0);

src/com/owncloud/android/ui/activity/FileActivity.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public abstract class FileActivity extends SherlockFragmentActivity {
4747
public static final String EXTRA_FILE = "com.owncloud.android.ui.activity.FILE";
4848
public static final String EXTRA_ACCOUNT = "com.owncloud.android.ui.activity.ACCOUNT";
4949
public static final String EXTRA_WAITING_TO_PREVIEW = "com.owncloud.android.ui.activity.WAITING_TO_PREVIEW";
50+
public static final String EXTRA_FROM_NOTIFICATION= "com.owncloud.android.ui.activity.FROM_NOTIFICATION";
5051

5152
public static final String TAG = FileActivity.class.getSimpleName();
5253

@@ -65,6 +66,9 @@ public abstract class FileActivity extends SherlockFragmentActivity {
6566

6667
/** Flag to signal when the value of mAccount was restored from a saved state */
6768
private boolean mAccountWasRestored;
69+
70+
/** Flag to signal if the activity is launched by a notification */
71+
private boolean mFromNotification;
6872

6973

7074
/**
@@ -82,9 +86,11 @@ protected void onCreate(Bundle savedInstanceState) {
8286
if(savedInstanceState != null) {
8387
account = savedInstanceState.getParcelable(FileActivity.EXTRA_ACCOUNT);
8488
mFile = savedInstanceState.getParcelable(FileActivity.EXTRA_FILE);
89+
mFromNotification = savedInstanceState.getBoolean(FileActivity.EXTRA_FROM_NOTIFICATION);
8590
} else {
8691
account = getIntent().getParcelableExtra(FileActivity.EXTRA_ACCOUNT);
8792
mFile = getIntent().getParcelableExtra(FileActivity.EXTRA_FILE);
93+
mFromNotification = getIntent().getBooleanExtra(FileActivity.EXTRA_FROM_NOTIFICATION, false);
8894
}
8995

9096
setAccount(account, savedInstanceState != null);
@@ -191,6 +197,7 @@ protected void onSaveInstanceState(Bundle outState) {
191197
super.onSaveInstanceState(outState);
192198
outState.putParcelable(FileActivity.EXTRA_FILE, mFile);
193199
outState.putParcelable(FileActivity.EXTRA_ACCOUNT, mAccount);
200+
outState.putBoolean(FileActivity.EXTRA_FROM_NOTIFICATION, mFromNotification);
194201
}
195202

196203

@@ -223,6 +230,12 @@ public Account getAccount() {
223230
return mAccount;
224231
}
225232

233+
/**
234+
* @return Value of mFromNotification: True if the Activity is launched by a notification
235+
*/
236+
public boolean fromNotification() {
237+
return mFromNotification;
238+
}
226239

227240
/**
228241
* @return 'True' when the Activity is finishing to enforce the setup of a new account.

src/com/owncloud/android/ui/activity/FileDisplayActivity.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,8 @@ protected void onCreate(Bundle savedInstanceState) {
162162
// PIN CODE request ; best location is to decide, let's try this first
163163
if (getIntent().getAction() != null && getIntent().getAction().equals(Intent.ACTION_MAIN) && savedInstanceState == null) {
164164
requestPinCode();
165+
} else if (getIntent().getAction() == null) {
166+
requestPinCode();
165167
}
166168

167169
/// file observer

0 commit comments

Comments
 (0)