eventbus: change slow consumer event from error to warn (libp2p#3286)

guillaumemichel · web-flow · commit c1c77458c242 · 2025-05-15T23:41:34.000+05:30
Closes ipfs/kubo#10778
diff --git a/p2p/host/eventbus/basic.go b/p2p/host/eventbus/basic.go
@@ -14,6 +14,7 @@ import (
 
 type logInterface interface {
 	Errorf(string, ...interface{})
+	Warnf(string, ...interface{})
 }
 
 var log logInterface = logging.Logger("eventbus")
@@ -464,7 +465,7 @@ func emitAndLogError(timer *time.Timer, typ reflect.Type, evt interface{}, sink
 			<-timer.C
 		}
 	case <-timer.C:
-		log.Errorf("subscriber named \"%s\" is a slow consumer of %s. This can lead to libp2p stalling and hard to debug issues.", sink.name, typ)
+		log.Warnf("subscriber named \"%s\" is a slow consumer of %s. This can lead to libp2p stalling and hard to debug issues.", sink.name, typ)
 		// Continue to stall since there's nothing else we can do.
 		sink.ch <- evt
 	}
diff --git a/p2p/host/eventbus/basic_test.go b/p2p/host/eventbus/basic_test.go
@@ -18,8 +18,10 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-type EventA struct{}
-type EventB int
+type (
+	EventA struct{}
+	EventB int
+)
 
 func getN() int {
 	n := 50000
@@ -144,6 +146,10 @@ func (m *mockLogger) Errorf(format string, args ...interface{}) {
 	m.logs = append(m.logs, fmt.Sprintf(format, args...))
 }
 
+func (m *mockLogger) Warnf(format string, args ...interface{}) {
+	m.Errorf(format, args...)
+}
+
 func (m *mockLogger) Logs() []string {
 	m.mu.Lock()
 	defer m.mu.Unlock()

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ import (`
`14`	`14`
`15`	`15`	`type logInterface interface {`
`16`	`16`	`Errorf(string, ...interface{})`
	`17`	`+ Warnf(string, ...interface{})`
`17`	`18`	`}`
`18`	`19`
`19`	`20`	`var log logInterface = logging.Logger("eventbus")`
`@@ -464,7 +465,7 @@ func emitAndLogError(timer *time.Timer, typ reflect.Type, evt interface{}, sink`
`464`	`465`	`<-timer.C`
`465`	`466`	`}`
`466`	`467`	`case <-timer.C:`
`467`		`- log.Errorf("subscriber named \"%s\" is a slow consumer of %s. This can lead to libp2p stalling and hard to debug issues.", sink.name, typ)`
	`468`	`+ log.Warnf("subscriber named \"%s\" is a slow consumer of %s. This can lead to libp2p stalling and hard to debug issues.", sink.name, typ)`
`468`	`469`	`// Continue to stall since there's nothing else we can do.`
`469`	`470`	`sink.ch <- evt`
`470`	`471`	`}`