Skip to content

Commit b7b79b4

Browse files
committed
added tests for ignoring hidden elements by default
1 parent eef5109 commit b7b79b4

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed

jquery.validate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ $.extend($.validator, {
212212
errorContainer: $( [] ),
213213
errorLabelContainer: $( [] ),
214214
onsubmit: true,
215-
ignore: [":hidden"],
215+
ignore: ":hidden",
216216
ignoreTitle: false,
217217
onfocusin: function(element) {
218218
this.lastActive = element;

test/test.js

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,3 +1137,30 @@ test("validate radio on click", function() {
11371137
trigger(e1);
11381138
errors(0);
11391139
});
1140+
1141+
test("ignore hidden elements", function(){
1142+
var form = $('#userForm');
1143+
var validate = form.validate({
1144+
rules:{
1145+
"username": "required"
1146+
}
1147+
});
1148+
form.get(0).reset();
1149+
ok(! validate.form(), "form should be initially invalid");
1150+
$('#userForm [name=username]').hide();
1151+
ok(validate.form(), "hidden elements should be ignored by default");
1152+
});
1153+
1154+
test("ignore hidden elements at start", function(){
1155+
var form = $('#userForm');
1156+
var validate = form.validate({
1157+
rules:{
1158+
"username": "required"
1159+
}
1160+
});
1161+
form.get(0).reset();
1162+
$('#userForm [name=username]').hide();
1163+
ok(validate.form(), "hidden elements should be ignored by default");
1164+
$('#userForm [name=username]').show();
1165+
ok(! validate.form(), "form should be invalid when required element is visible");
1166+
});

0 commit comments

Comments
 (0)