Dont update config

barryvdh · barryvdh · commit 765bffc94406 · 2016-04-16T22:34:46.000+02:00
Should fix config caching + concurrent requests.
diff --git a/src/LaravelDebugbar.php b/src/LaravelDebugbar.php
@@ -70,6 +70,13 @@ class LaravelDebugbar extends DebugBar
      */
     protected $booted = false;
 
+    /**
+     * True when enabled, false disabled an null for still unknown
+     *
+     * @var bool
+     */
+    protected $enabled = null;
+
     /**
      * True when this is a Lumen application
      *
@@ -95,7 +102,8 @@ public function __construct($app = null)
      */
     public function enable()
     {
-        $this->app['config']->set('debugbar.enabled', true);
+        $this->enabled = true;
+
         if (!$this->booted) {
             $this->boot();
         }
@@ -580,10 +588,6 @@ public function modifyResponse(Request $request, Response $response)
             }
         }
 
-
-        // Stop further rendering (on subrequests etc)
-        $this->disable();
-
         return $response;
     }
 
@@ -593,7 +597,11 @@ public function modifyResponse(Request $request, Response $response)
      */
     public function isEnabled()
     {
-        return value($this->app['config']->get('debugbar.enabled'));
+        if ($this->enabled === null) {
+            $this->enabled = value($this->app['config']->get('debugbar.enabled'));
+        }
+
+        return $this->enabled;
     }
 
     /**
@@ -697,7 +705,7 @@ public function injectDebugbar(Response $response)
      */
     public function disable()
     {
-        $this->app['config']->set('debugbar.enabled', false);
+        $this->enabled = false;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,13 @@ class LaravelDebugbar extends DebugBar`
`70`	`70`	`*/`
`71`	`71`	`protected $booted = false;`
`72`	`72`
	`73`	`+ /**`
	`74`	`+ * True when enabled, false disabled an null for still unknown`
	`75`	`+ *`
	`76`	`+ * @var bool`
	`77`	`+ */`
	`78`	`+ protected $enabled = null;`
	`79`	`+`
`73`	`80`	`/**`
`74`	`81`	`* True when this is a Lumen application`
`75`	`82`	`*`
`@@ -95,7 +102,8 @@ public function __construct($app = null)`
`95`	`102`	`*/`
`96`	`103`	`public function enable()`
`97`	`104`	`{`
`98`		`- $this->app['config']->set('debugbar.enabled', true);`
	`105`	`+ $this->enabled = true;`
	`106`	`+`
`99`	`107`	`if (!$this->booted) {`
`100`	`108`	`$this->boot();`
`101`	`109`	`}`
`@@ -580,10 +588,6 @@ public function modifyResponse(Request $request, Response $response)`
`580`	`588`	`}`
`581`	`589`	`}`
`582`	`590`
`583`		`-`
`584`		`- // Stop further rendering (on subrequests etc)`
`585`		`- $this->disable();`
`586`		`-`
`587`	`591`	`return $response;`
`588`	`592`	`}`
`589`	`593`
`@@ -593,7 +597,11 @@ public function modifyResponse(Request $request, Response $response)`
`593`	`597`	`*/`
`594`	`598`	`public function isEnabled()`
`595`	`599`	`{`
`596`		`- return value($this->app['config']->get('debugbar.enabled'));`
	`600`	`+ if ($this->enabled === null) {`
	`601`	`+ $this->enabled = value($this->app['config']->get('debugbar.enabled'));`
	`602`	`+ }`
	`603`	`+`
	`604`	`+ return $this->enabled;`
`597`	`605`	`}`
`598`	`606`
`599`	`607`	`/**`
`@@ -697,7 +705,7 @@ public function injectDebugbar(Response $response)`
`697`	`705`	`*/`
`698`	`706`	`public function disable()`
`699`	`707`	`{`
`700`		`- $this->app['config']->set('debugbar.enabled', false);`
	`708`	`+ $this->enabled = false;`
`701`	`709`	`}`
`702`	`710`
`703`	`711`	`/**`