Test pyflyby on CI as a downstream project (#14957)

krassowski · web-flow · commit ad948680afae · 2025-08-21T15:44:41.000+01:00
`pyflyby` includes an extension to IPython which integrates tightly with a substantial part of the IPython API. Previous IPython releases broke `pyflyby` functionality; this may be acceptable if it happens in major releases, but there were instances were minor releases introduced incompatibilities which lead to downstream breakages. This PR includes a single `pyflyby` test file that verifies the IPython-related integration in the downstream testing job. This is meant to serve as a canary test for breaking API changes in the completer, interactive help, and debug magics, all covered in the `pyflyby` test suite. Should we decide that this is no longer needed, or that it introduces too much noise, this PR could be reverted in the future, but as of now it makes releasing new versions much easier as it alleviates the worry about breaking downstream functionality. Before merging deshaw/pyflyby#398: ``` ======= 5 failed, 114 passed, 30 skipped, 5 xfailed in 193.70s (0:03:13) ======= ``` After: ``` ======= 8 failed, 134 passed, 14 skipped, 2 xfailed in 344.92s (0:05:44) ======= ```
diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml
@@ -75,3 +75,16 @@ jobs:
         # cd ../sage/
         # # From https://github.com/sagemath/sage/blob/develop/pkgs/sagemath-repl/tox.ini
         # sage-runtests -p --environment=sage.all__sagemath_repl --baseline-stats-path=pkgs/sagemath-repl/known-test-failures.json --initial --optional=sage src/sage/repl src/sage/doctest src/sage/misc/sage_input.py src/sage/misc/sage_eval.py
+    - name: Install pyflyby
+      run: |
+        cd ..
+        git clone https://github.com/deshaw/pyflyby
+        cd pyflyby
+        pip install -e .
+        # TODO: use [test] group instead once available
+        pip install 'pytest<=8' requests
+        cd ..
+    - name: Test pyflyby (IPython integration only)
+      run: |
+        cd ../pyflyby
+        pytest tests/test_interactive.py -k 'not test_timeit_complete_autoimport_member_1'
