style(*): IE is a real browser, and chakra is pretty solid

caitp · caitp · commit 4c218de4d3cc · 2014-11-26T14:39:23.000-06:00
- IE9+ do not have issues with Function.prototype.apply() on builtin fns (asked Brian Terlson) (NOTE: there may still be corner cases where builtins will not have `apply()` --- this may need to be reverted on complaint). - HTMLScriptElement#text is an IDL-spec'd attribute, and we use it in all cases --- so the comment was sort of nonsense. - The value of `msie` does not depend on whether the user is using a "real" browser or not. Closes angular#10242
diff --git a/src/Angular.js b/src/Angular.js
@@ -155,8 +155,8 @@ if ('i' !== 'I'.toLowerCase()) {
 }
 
 
-var /** holds major version number for IE or NaN for real browsers */
-    msie,
+var
+    msie,             // holds major version number for IE, or NaN if UA is not IE.
     jqLite,           // delay binding since jQuery could be loaded after us.
     jQuery,           // delay binding
     slice             = [].slice,
diff --git a/src/ng/directive/script.js b/src/ng/directive/script.js
@@ -40,7 +40,6 @@ var scriptDirective = ['$templateCache', function($templateCache) {
     compile: function(element, attr) {
       if (attr.type == 'text/ng-template') {
         var templateUrl = attr.id,
-            // IE is not consistent, in scripts we have to read .text but in other nodes we have to read .textContent
             text = element[0].text;
 
         $templateCache.put(templateUrl, text);
diff --git a/src/ng/parse.js b/src/ng/parse.js
@@ -762,7 +762,7 @@ Parser.prototype = {
       ensureSafeObject(context, parser.text);
       ensureSafeFunction(fnPtr, parser.text);
 
-      // IE stupidity! (IE doesn't have apply for some native functions)
+      // IE doesn't have apply for some native functions
       var v = fnPtr.apply
             ? fnPtr.apply(context, args)
             : fnPtr(args[0], args[1], args[2], args[3], args[4]);

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,8 @@ if ('i' !== 'I'.toLowerCase()) {`
`155`	`155`	`}`
`156`	`156`
`157`	`157`
`158`		`-var /** holds major version number for IE or NaN for real browsers */`
`159`		`- msie,`
	`158`	`+var`
	`159`	`+ msie, // holds major version number for IE, or NaN if UA is not IE.`
`160`	`160`	`jqLite, // delay binding since jQuery could be loaded after us.`
`161`	`161`	`jQuery, // delay binding`
`162`	`162`	`slice = [].slice,`