Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: java-to-kotlin/testing-auto-spawn-points
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: java-to-kotlin/testing-auto-spawn-points
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: spawn-points
Choose a head ref
  • 12 commits
  • 23 files changed
  • 1 contributor

Commits on May 27, 2025

  1. ReverseAuction.decideWinner refactored to pipeline

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    2f260d7 View commit details
    Browse the repository at this point in the history

  2. End of ReverseAuction.decideWinner refactor

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    956e3ab View commit details
    Browse the repository at this point in the history

  3. Eliminate unnecessary mutability

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    508eafb View commit details
    Browse the repository at this point in the history

  4. Use strategy for decideWinner

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    9b4862e View commit details
    Browse the repository at this point in the history

  5. Auction inheritance replaced by factory functions and Strategy pattern

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    54b2975 View commit details
    Browse the repository at this point in the history

  6. Make Auction.bids immutable

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    c54da90 View commit details
    Browse the repository at this point in the history

  7. Auction is entirely immutable

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    00a0eb6 View commit details
    Browse the repository at this point in the history

  8. Make Auction.placeBid return Result<Auction, Exception>

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    a576abe View commit details
    Browse the repository at this point in the history

  9. Make AuctionService.placeBid return Result<Auction, Exception>

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    7dab18e View commit details
    Browse the repository at this point in the history

  10. Return ResponseEntity from AuctionController.recordBid

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    7cb1ed7 View commit details
    Browse the repository at this point in the history

  11. Make the exceptions of placeBid implement a sealed class hieararchy s… 

    …o that we know what they are
    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    129f498 View commit details
    Browse the repository at this point in the history

  12. All Auction errors are reported as Results

    @npryce
    npryce committed May 27, 2025
    Configuration menu
    Copy the full SHA
    55d1089 View commit details
    Browse the repository at this point in the history
Loading