Skip to content

Commit b451796

Browse files
bbakermanbbakerman
authored
Code health - semi colons and * imports (graphql-java#766)
1 parent 9b1c7f6 commit b451796

File tree

52 files changed

+376
-209
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+376
-209
lines changed

‎src/main/java/graphql/validation/rules/ArgumentsOfCorrectType.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33

44
import graphql.language.Argument;
55
import graphql.schema.GraphQLArgument;
6-
import graphql.validation.*;
6+
import graphql.validation.AbstractRule;
7+
import graphql.validation.ArgumentValidationUtil;
8+
import graphql.validation.ValidationContext;
9+
import graphql.validation.ValidationError;
10+
import graphql.validation.ValidationErrorCollector;
11+
import graphql.validation.ValidationErrorType;
712

813
public class ArgumentsOfCorrectType extends AbstractRule {
914

‎src/main/java/graphql/validation/rules/FragmentsOnCompositeType.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
import graphql.language.InlineFragment;
66
import graphql.schema.GraphQLCompositeType;
77
import graphql.schema.GraphQLType;
8-
import graphql.validation.*;
8+
import graphql.validation.AbstractRule;
9+
import graphql.validation.ValidationContext;
10+
import graphql.validation.ValidationError;
11+
import graphql.validation.ValidationErrorCollector;
12+
import graphql.validation.ValidationErrorType;
913

1014
public class FragmentsOnCompositeType extends AbstractRule {
1115

‎src/main/java/graphql/validation/rules/KnownArgumentNames.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
import graphql.schema.GraphQLArgument;
55
import graphql.schema.GraphQLDirective;
66
import graphql.schema.GraphQLFieldDefinition;
7-
import graphql.validation.*;
7+
import graphql.validation.AbstractRule;
8+
import graphql.validation.ValidationContext;
9+
import graphql.validation.ValidationError;
10+
import graphql.validation.ValidationErrorCollector;
11+
import graphql.validation.ValidationErrorType;
812

913

1014
public class KnownArgumentNames extends AbstractRule {

‎src/main/java/graphql/validation/rules/KnownDirectives.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,20 @@
22

33

44
import graphql.introspection.Introspection.DirectiveLocation;
5-
import graphql.language.*;
5+
import graphql.language.Directive;
6+
import graphql.language.Field;
7+
import graphql.language.FragmentDefinition;
8+
import graphql.language.FragmentSpread;
9+
import graphql.language.InlineFragment;
10+
import graphql.language.Node;
11+
import graphql.language.OperationDefinition;
612
import graphql.language.OperationDefinition.Operation;
713
import graphql.schema.GraphQLDirective;
8-
import graphql.validation.*;
14+
import graphql.validation.AbstractRule;
15+
import graphql.validation.ValidationContext;
16+
import graphql.validation.ValidationError;
17+
import graphql.validation.ValidationErrorCollector;
18+
import graphql.validation.ValidationErrorType;
919

1020
import java.util.List;
1121

@@ -41,7 +51,7 @@ private boolean hasInvalidLocation(GraphQLDirective directive, Node ancestor) {
4151
} else if (ancestor instanceof Field) {
4252
return !(directive.validLocations().contains(DirectiveLocation.FIELD) || directive.isOnField());
4353
} else if (ancestor instanceof FragmentSpread) {
44-
return !(directive.validLocations().contains(DirectiveLocation.FRAGMENT_SPREAD) || directive.isOnFragment());
54+
return !(directive.validLocations().contains(DirectiveLocation.FRAGMENT_SPREAD) || directive.isOnFragment());
4555
} else if (ancestor instanceof FragmentDefinition) {
4656
return !(directive.validLocations().contains(DirectiveLocation.FRAGMENT_DEFINITION) || directive.isOnFragment());
4757
} else if (ancestor instanceof InlineFragment) {

‎src/main/java/graphql/validation/rules/KnownFragmentNames.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33

44
import graphql.language.FragmentDefinition;
55
import graphql.language.FragmentSpread;
6-
import graphql.validation.*;
6+
import graphql.validation.AbstractRule;
7+
import graphql.validation.ValidationContext;
8+
import graphql.validation.ValidationError;
9+
import graphql.validation.ValidationErrorCollector;
10+
import graphql.validation.ValidationErrorType;
711

812
public class KnownFragmentNames extends AbstractRule {
913

‎src/main/java/graphql/validation/rules/KnownTypeNames.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22

33

44
import graphql.language.TypeName;
5-
import graphql.validation.*;
5+
import graphql.validation.AbstractRule;
6+
import graphql.validation.ValidationContext;
7+
import graphql.validation.ValidationError;
8+
import graphql.validation.ValidationErrorCollector;
9+
import graphql.validation.ValidationErrorType;
610

711
public class KnownTypeNames extends AbstractRule {
812

‎src/main/java/graphql/validation/rules/NoUndefinedVariables.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
import graphql.language.OperationDefinition;
66
import graphql.language.VariableDefinition;
77
import graphql.language.VariableReference;
8-
import graphql.validation.*;
8+
import graphql.validation.AbstractRule;
9+
import graphql.validation.ValidationContext;
10+
import graphql.validation.ValidationError;
11+
import graphql.validation.ValidationErrorCollector;
12+
import graphql.validation.ValidationErrorType;
913

1014
import java.util.LinkedHashSet;
1115
import java.util.Set;

‎src/main/java/graphql/validation/rules/NoUnusedFragments.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
import graphql.language.FragmentDefinition;
66
import graphql.language.FragmentSpread;
77
import graphql.language.OperationDefinition;
8-
import graphql.validation.*;
8+
import graphql.validation.AbstractRule;
9+
import graphql.validation.ValidationContext;
10+
import graphql.validation.ValidationError;
11+
import graphql.validation.ValidationErrorCollector;
12+
import graphql.validation.ValidationErrorType;
913

1014
import java.util.ArrayList;
1115
import java.util.LinkedHashMap;

‎src/main/java/graphql/validation/rules/NoUnusedVariables.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
import graphql.language.OperationDefinition;
55
import graphql.language.VariableDefinition;
66
import graphql.language.VariableReference;
7-
import graphql.validation.*;
7+
import graphql.validation.AbstractRule;
8+
import graphql.validation.ValidationContext;
9+
import graphql.validation.ValidationError;
10+
import graphql.validation.ValidationErrorCollector;
11+
import graphql.validation.ValidationErrorType;
812

913
import java.util.ArrayList;
1014
import java.util.LinkedHashSet;

‎src/main/java/graphql/validation/rules/ProvidedNonNullArguments.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
import graphql.schema.GraphQLDirective;
1010
import graphql.schema.GraphQLFieldDefinition;
1111
import graphql.schema.GraphQLNonNull;
12-
import graphql.validation.*;
12+
import graphql.validation.AbstractRule;
13+
import graphql.validation.ValidationContext;
14+
import graphql.validation.ValidationError;
15+
import graphql.validation.ValidationErrorCollector;
16+
import graphql.validation.ValidationErrorType;
1317

1418
import java.util.LinkedHashMap;
1519
import java.util.List;

0 commit comments

Comments
 (0)