No text selection for Label, Link, Group and other widgets, so DND on Shell won't get text selection, and DND behavior will be a lot smoother.

zhourenjian · zhourenjian · commit 54db23ceff00 · 2009-04-26T08:10:15.000Z
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/custom/CLabel.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/custom/CLabel.java
@@ -403,6 +403,7 @@ public void redraw() {
 			textHandle = document.createElement("DIV");
 			textHandle.className = "clabel-text";
 			this.containerHandle().appendChild(textHandle);
+			OS.setTextSelection(textHandle, false);
 		}
 		OS.clearChildren(textHandle);
 	} else {
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/internal/browser/OS.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/internal/browser/OS.java
@@ -156,6 +156,8 @@ private static void init() {
 			s.height = "100px";
 			s.overflow = "scroll";
 			invisibleContainer = el;
+			setTextSelection(el, false);
+			
 			containers = new Object();
 			
 			el = document.createElement ("DIV");
@@ -995,4 +997,14 @@ public static boolean isInputCharacter(int keyCode, boolean shiftKey, boolean al
 		return false;
 	}
 
+	/**
+	 * @j2sNative
+	 * if (O$.isMozilla || O$.isFirefox) {
+	 * 	handle.style.MozUserSelect = enabled ? "all" : "none";
+	 * } else if (typeof handle.onselectstart != "undefined") {
+	 * 	handle.onselectstart = enabled ? null : function () { return false; };
+	 * }
+	 */
+	public static void setTextSelection(Element handle, boolean enabled) {
+	}
 }
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Button.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Button.java
@@ -529,6 +529,8 @@ public void run() {
 	};
 	//bindHandle();
 	hookSelection();
+	
+	OS.setTextSelection(this.handle, false);
 }
 
 /*
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Group.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Group.java
@@ -286,6 +286,7 @@ protected void createHandle () {
 	contentBox = (Element) createCSSElement(handle, "group-content-box");
 	content = (Element) createCSSElement(contentBox, "group-content");
 	
+	OS.setTextSelection(this.titleText, false);
 }
 
 public Rectangle getClientArea () {
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Label.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Label.java
@@ -714,6 +714,8 @@ void createHandle() {
 			parentHandle.appendChild(handle);
 		}
 	}
+	
+	OS.setTextSelection(this.handle, false);
 }
 
 public void setBounds(int x, int y, int width, int height) {
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Link.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/Link.java
@@ -239,6 +239,8 @@ void createHandle () {
 			parentHandle.appendChild(handle);
 		}
 	}
+	
+	OS.setTextSelection(this.handle, false);
 }
 
 void createWidget () {
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/TabFolder.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/TabFolder.java
@@ -375,6 +375,8 @@ void createItem (TabItem item, final int index) {
 		sendEvent (SWT.Selection, event);
 		// the widget could be destroyed at this point
 	}
+	
+	OS.setTextSelection(tab, false);
 }
 
 protected void createHandle () {
diff --git a/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/ToolItem.java b/sources/net.sf.j2s.java.org.eclipse.swt/src/org/eclipse/swt/widgets/ToolItem.java
@@ -1283,7 +1283,9 @@ public void setText (String string) {
 			}
 			OS.clearChildren(textEl);
 		}
-		textEl.appendChild(document.createTextNode(string));
+		textEl.appendChild(document.createTextNode(string));
+		
+		OS.setTextSelection(textEl, false);
 	}
 	
 	parent.layoutItems ();

Original file line number	Diff line number	Diff line change
`@@ -403,6 +403,7 @@ public void redraw() {`
`403`	`403`	`textHandle = document.createElement("DIV");`
`404`	`404`	`textHandle.className = "clabel-text";`
`405`	`405`	`this.containerHandle().appendChild(textHandle);`
	`406`	`+ OS.setTextSelection(textHandle, false);`
`406`	`407`	`}`
`407`	`408`	`OS.clearChildren(textHandle);`
`408`	`409`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -529,6 +529,8 @@ public void run() {`
`529`	`529`	`};`
`530`	`530`	`//bindHandle();`
`531`	`531`	`hookSelection();`
	`532`	`+`
	`533`	`+ OS.setTextSelection(this.handle, false);`
`532`	`534`	`}`
`533`	`535`
`534`	`536`	`/*`
Original file line number	Diff line number	Diff line change
`@@ -286,6 +286,7 @@ protected void createHandle () {`
`286`	`286`	`contentBox = (Element) createCSSElement(handle, "group-content-box");`
`287`	`287`	`content = (Element) createCSSElement(contentBox, "group-content");`
`288`	`288`
	`289`	`+ OS.setTextSelection(this.titleText, false);`
`289`	`290`	`}`
`290`	`291`
`291`	`292`	`public Rectangle getClientArea () {`
Original file line number	Diff line number	Diff line change
`@@ -714,6 +714,8 @@ void createHandle() {`
`714`	`714`	`parentHandle.appendChild(handle);`
`715`	`715`	`}`
`716`	`716`	`}`
	`717`	`+`
	`718`	`+ OS.setTextSelection(this.handle, false);`
`717`	`719`	`}`
`718`	`720`
`719`	`721`	`public void setBounds(int x, int y, int width, int height) {`
Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,8 @@ void createHandle () {`
`239`	`239`	`parentHandle.appendChild(handle);`
`240`	`240`	`}`
`241`	`241`	`}`
	`242`	`+`
	`243`	`+ OS.setTextSelection(this.handle, false);`
`242`	`244`	`}`
`243`	`245`
`244`	`246`	`void createWidget () {`
Original file line number	Diff line number	Diff line change
`@@ -375,6 +375,8 @@ void createItem (TabItem item, final int index) {`
`375`	`375`	`sendEvent (SWT.Selection, event);`
`376`	`376`	`// the widget could be destroyed at this point`
`377`	`377`	`}`
	`378`	`+`
	`379`	`+ OS.setTextSelection(tab, false);`
`378`	`380`	`}`
`379`	`381`
`380`	`382`	`protected void createHandle () {`
Original file line number	Diff line number	Diff line change
`@@ -1283,7 +1283,9 @@ public void setText (String string) {`
`1283`	`1283`	`}`
`1284`	`1284`	`OS.clearChildren(textEl);`
`1285`	`1285`	`}`
`1286`		`- textEl.appendChild(document.createTextNode(string));`
	`1286`	`+ textEl.appendChild(document.createTextNode(string));`
	`1287`	`+`
	`1288`	`+ OS.setTextSelection(textEl, false);`
`1287`	`1289`	`}`
`1288`	`1290`
`1289`	`1291`	`parent.layoutItems ();`