Skip to content

Fix issue when resolving a static method-call with only a generic variadic parameter #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Fix issue when resolving a static method-call with only a generic variadic parameter #3194

wants to merge 16 commits into from

Conversation

maartenc
Copy link
Contributor

Fixes #3183.

@maartenc maartenc marked this pull request as draft March 24, 2021 23:27
This was referenced Mar 25, 2021
Closed
Closed
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #3194 (7866075) into master (808b682) will decrease coverage by 0.035%.
The diff coverage is 53.488%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3194       +/-   ##
===============================================
- Coverage     57.339%   57.303%   -0.036%     
+ Complexity      2567      2553       -14     
===============================================
  Files            616       616               
  Lines          34303     34277       -26     
  Branches        5802      5796        -6     
===============================================
- Hits           19669     19642       -27     
+ Misses         12665     12663        -2     
- Partials        1969      1972        +3
Flag Coverage Δ Complexity Δ
AlsoSlowTests 57.303% <53.488%> (-0.036%) 5315.000 <8.000> (-12.000)
javaparser-core 52.945% <0.000%> (-0.037%) 0.000 <0.000> (ø)
javaparser-symbol-solver 35.391% <53.488%> (-0.052%) 5315.000 <10.000> (-12.000)
jdk-10 57.297% <53.488%> (-0.035%) 5315.000 <8.000> (-12.000)
jdk-11 57.297% <53.488%> (-0.035%) 5315.000 <8.000> (-12.000)
jdk-12 57.297% <53.488%> (-0.035%) 5315.000 <8.000> (-12.000)
jdk-13 57.294% <53.488%> (-0.037%) 5315.000 <8.000> (-12.000)
jdk-14 57.294% <53.488%> (-0.037%) 5315.000 <8.000> (-11.000)
jdk-15 57.297% <53.488%> (-0.035%) 5315.000 <8.000> (-12.000)
jdk-16 57.297% <53.488%> (-0.035%) 5313.000 <8.000> (-13.000)
jdk-8 57.301% <53.488%> (-0.033%) 5313.000 <8.000> (-11.000)
jdk-9 57.297% <53.488%> (-0.035%) 5315.000 <8.000> (-11.000)
macos-latest 57.294% <53.488%> (-0.036%) 5312.000 <8.000> (-12.000)
ubuntu-latest 57.289% <53.488%> (-0.036%) 5312.000 <8.000> (-12.000)
windows-latest 57.294% <53.488%> (-0.036%) 5315.000 <8.000> (-12.000)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...aparser/resolution/types/ResolvedTypeVariable.java 63.043% <27.777%> (-22.671%) 0.000 <0.000> (ø)
...avaparsermodel/contexts/MethodCallExprContext.java 77.157% <72.000%> (+0.808%) 75.000 <8.000> (-14.000) ⬆️
...symbolsolver/reflectionmodel/MyObjectProvider.java 57.142% <0.000%> (-14.286%) 2.000% <0.000%> (-1.000%)
...parser/resolution/types/ResolvedReferenceType.java 81.052% <0.000%> (-0.527%) 0.000% <0.000%> (ø%)
...symbolsolver/resolution/MethodResolutionLogic.java 76.178% <0.000%> (+0.248%) 172.000% <0.000%> (+1.000%)
...declarations/ResolvedTypeParameterDeclaration.java 27.272% <0.000%> (+1.818%) 0.000% <0.000%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808b682...7866075. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method call resolution fails with UnsolvedSymbolException if passed parameter is a list of two or more elements
3 participants
@maartenc @jlerbsc @MysterAitch