include VIP access icon in otpauth:// URI

dlenski · dlenski · commit f73f1e08a37b · 2020-11-30T20:31:07.000-08:00
diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -86,7 +86,7 @@ def test_generate_totp_uri():
         'timeskew': 0,
     }
     test_secret = b'ZqeD\xd9wg]"\x12\x1f7\xc7v6"\xf0\x13\\i'
-    expected_uri = urlparse.urlparse('otpauth://totp/VIP%20Access:SYMC26070843?secret=LJYWKRGZO5TV2IQSD434O5RWELYBGXDJ&issuer=Symantec&digits=6&algorithm=SHA1&period=30')
+    expected_uri = urlparse.urlparse('otpauth://totp/VIP%20Access:SYMC26070843?secret=LJYWKRGZO5TV2IQSD434O5RWELYBGXDJ&issuer=Symantec&digits=6&algorithm=SHA1&period=30&image=https://vip.symantec.com/favicon.ico')
     generated_uri = urlparse.urlparse(generate_otp_uri(test_token, test_secret))
     assert generated_uri.scheme == expected_uri.scheme
     assert generated_uri.netloc == expected_uri.netloc
@@ -110,7 +110,7 @@ def test_generate_hotp_uri():
         'timeskew': 0,
     }
     test_secret = b'\x9a\x13\xcd2!\xad\xbd\x97R\xfcEE\xb6\x92e\xb4\x14\xb0\xfem'
-    expected_uri = urlparse.urlparse('otpauth://hotp/VIP%20Access:UBHE57586348?digits=6&algorithm=SHA1&counter=1&issuer=Symantec&secret=TIJ42MRBVW6ZOUX4IVC3NETFWQKLB7TN')
+    expected_uri = urlparse.urlparse('otpauth://hotp/VIP%20Access:UBHE57586348?digits=6&algorithm=SHA1&counter=1&issuer=Symantec&secret=TIJ42MRBVW6ZOUX4IVC3NETFWQKLB7TN&image=https://vip.symantec.com/favicon.ico')
     generated_uri = urlparse.urlparse(generate_otp_uri(test_token, test_secret))
     assert generated_uri.scheme == expected_uri.scheme
     assert generated_uri.netloc == expected_uri.netloc
diff --git a/vipaccess/provision.py b/vipaccess/provision.py
@@ -174,7 +174,7 @@ def decrypt_key(token_iv, token_cipher):
 
     return otp_key
 
-def generate_otp_uri(token, secret, issuer='Symantec'):
+def generate_otp_uri(token, secret, issuer='Symantec', image='https://vip.symantec.com/favicon.ico'):
     '''Generate the OTP URI.'''
     token_parameters = {}
     token_parameters['app_name'] = urllib.quote('VIP Access')
@@ -185,6 +185,7 @@ def generate_otp_uri(token, secret, issuer='Symantec'):
         digits=token.get('digits', 6),
         algorithm=token.get('algorithm', 'SHA1').upper(),
         issuer=issuer,
+        image=image,
     )
     if token.get('counter') is not None: # HOTP
         data['counter'] = token['counter']
