Merge pull request DesignPatternsPHP#221 from krizalys/fix-style

Dominik Liebler · web-flow · commit 9ef1f8bb0bb1 · 2016-06-16T15:06:14.000+02:00
Fixed style
diff --git a/Behavioral/Iterator/BookList.php b/Behavioral/Iterator/BookList.php
@@ -11,8 +11,6 @@ public function getBook($bookNumberToGet)
         if (isset($this->books[$bookNumberToGet])) {
             return $this->books[$bookNumberToGet];
         }
-
-        return;
     }
 
     public function addBook(Book $book)
diff --git a/Behavioral/TemplateMethod/Journey.php b/Behavioral/TemplateMethod/Journey.php
@@ -2,9 +2,6 @@
 
 namespace DesignPatterns\Behavioral\TemplateMethod;
 
-/**
- *
- */
 abstract class Journey
 {
     /**
diff --git a/Creational/Builder/BuilderInterface.php b/Creational/Builder/BuilderInterface.php
@@ -2,9 +2,6 @@
 
 namespace DesignPatterns\Creational\Builder;
 
-/**
- *
- */
 interface BuilderInterface
 {
     /**
diff --git a/Structural/Facade/Tests/FacadeTest.php b/Structural/Facade/Tests/FacadeTest.php
@@ -34,7 +34,7 @@ public function getComputer()
     }
 
     /**
-     * @param Computer $facade
+     * @param Computer    $facade
      * @param OsInterface $os
      * @dataProvider getComputer
      */
diff --git a/Structural/Flyweight/CharacterFlyweight.php b/Structural/Flyweight/CharacterFlyweight.php
@@ -11,6 +11,7 @@ class CharacterFlyweight implements FlyweightInterface
     /**
      * Any state stored by the concrete flyweight must be independent of its context.
      * For flyweights representing characters, this is usually the corresponding character code.
+     *
      * @var string
      */
     private $name;
@@ -25,7 +26,7 @@ public function __construct($name)
 
     /**
      * Clients supply the context-dependent information that the flyweight needs to draw itself
-     * For flyweights representing characters, extrinsic state usually contains e.g. the font
+     * For flyweights representing characters, extrinsic state usually contains e.g. the font.
      *
      * @param string $font
      */
diff --git a/Structural/Flyweight/FlyweightFactory.php b/Structural/Flyweight/FlyweightFactory.php
@@ -2,33 +2,32 @@
 
 namespace DesignPatterns\Structural\Flyweight;
 
-use DesignPatterns\Structural\Flyweight\CharacterFlyweight;
-
 /**
  * A factory manages shared flyweights. Clients shouldn't instaniate them directly,
  * but let the factory take care of returning existing objects or creating new ones.
  */
 class FlyweightFactory
 {
     /**
-     * Associative store for flyweight objects
+     * Associative store for flyweight objects.
      *
-     * @var Array
+     * @var array
      */
     private $pool = array();
 
     /**
-     * Magic getter
+     * Magic getter.
      *
      * @param string $name
+     *
      * @return Flyweight
      */
     public function __get($name)
     {
         if (!array_key_exists($name, $this->pool)) {
             $this->pool[$name] = new CharacterFlyweight($name);
         }
-        
+
         return $this->pool[$name];
     }
 
diff --git a/Structural/Flyweight/FlyweightInterface.php b/Structural/Flyweight/FlyweightInterface.php
@@ -3,7 +3,7 @@
 namespace DesignPatterns\Structural\Flyweight;
 
 /**
- * An interface through which flyweights can receive and act on extrinsic state
+ * An interface through which flyweights can receive and act on extrinsic state.
  */
 interface FlyweightInterface
 {
diff --git a/Structural/Flyweight/Tests/FlyweightTest.php b/Structural/Flyweight/Tests/FlyweightTest.php
@@ -6,12 +6,12 @@
 
 /**
  * FlyweightTest demonstrates how a client would use the flyweight structure
- * You don't have to change the code of your client
+ * You don't have to change the code of your client.
  */
 class FlyweightTest extends \PHPUnit_Framework_TestCase
 {
     private $characters = array('a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k',
-        'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z');
+        'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', );
     private $fonts = array('Arial', 'Times New Roman', 'Verdana', 'Helvetica');
 
     // This is about the number of characters in a book of average length
@@ -31,6 +31,6 @@ public function testFlyweight()
 
         // Flyweight pattern ensures that instances are shared
         // instead of having hundreds of thousands of individual objects
-        $this->assertLessThanOrEqual($factory->totalNumber(), sizeof($this->characters));
+        $this->assertLessThanOrEqual($factory->totalNumber(), count($this->characters));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@ public function getBook($bookNumberToGet)`
`11`	`11`	`if (isset($this->books[$bookNumberToGet])) {`
`12`	`12`	`return $this->books[$bookNumberToGet];`
`13`	`13`	`}`
`14`		`-`
`15`		`- return;`
`16`	`14`	`}`
`17`	`15`
`18`	`16`	`public function addBook(Book $book)`
Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,6 @@`
`2`	`2`
`3`	`3`	`namespace DesignPatterns\Behavioral\TemplateMethod;`
`4`	`4`
`5`		`-/**`
`6`		`- *`
`7`		`- */`
`8`	`5`	`abstract class Journey`
`9`	`6`	`{`
`10`	`7`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,6 @@`
`2`	`2`
`3`	`3`	`namespace DesignPatterns\Creational\Builder;`
`4`	`4`
`5`		`-/**`
`6`		`- *`
`7`		`- */`
`8`	`5`	`interface BuilderInterface`
`9`	`6`	`{`
`10`	`7`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function getComputer()`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`/**`
`37`		`- * @param Computer $facade`
	`37`	`+ * @param Computer $facade`
`38`	`38`	`* @param OsInterface $os`
`39`	`39`	`* @dataProvider getComputer`
`40`	`40`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`namespace DesignPatterns\Structural\Flyweight;`
`4`	`4`
`5`	`5`	`/**`
`6`		`- * An interface through which flyweights can receive and act on extrinsic state`
	`6`	`+ * An interface through which flyweights can receive and act on extrinsic state.`
`7`	`7`	`*/`
`8`	`8`	`interface FlyweightInterface`
`9`	`9`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,12 +6,12 @@`
`6`	`6`
`7`	`7`	`/**`
`8`	`8`	`* FlyweightTest demonstrates how a client would use the flyweight structure`
`9`		`- * You don't have to change the code of your client`
	`9`	`+ * You don't have to change the code of your client.`
`10`	`10`	`*/`
`11`	`11`	`class FlyweightTest extends \PHPUnit_Framework_TestCase`
`12`	`12`	`{`
`13`	`13`	`private $characters = array('a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k',`
`14`		`- 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z');`
	`14`	`+ 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', );`
`15`	`15`	`private $fonts = array('Arial', 'Times New Roman', 'Verdana', 'Helvetica');`
`16`	`16`
`17`	`17`	`// This is about the number of characters in a book of average length`
`@@ -31,6 +31,6 @@ public function testFlyweight()`
`31`	`31`
`32`	`32`	`// Flyweight pattern ensures that instances are shared`
`33`	`33`	`// instead of having hundreds of thousands of individual objects`
`34`		`- $this->assertLessThanOrEqual($factory->totalNumber(), sizeof($this->characters));`
	`34`	`+ $this->assertLessThanOrEqual($factory->totalNumber(), count($this->characters));`
`35`	`35`	`}`
`36`	`36`	`}`