fix regression, make sure to round color components when outputting

leafo · leafo · commit 0010e7fea894 · 2012-02-26T01:52:37.000-08:00
diff --git a/lessc.inc.php b/lessc.inc.php
@@ -1404,10 +1404,15 @@ function compileValue($value) {
 			// [2] - green component
 			// [3] - blue component
 			// [4] - optional alpha component
+			list(, $r, $g, $b) = $value;
+			$r = round($r);
+			$g = round($g);
+			$b = round($b);
+
 			if (count($value) == 5 && $value[4] != 1) { // rgba
-				return 'rgba('.$value[1].','.$value[2].','.$value[3].','.$value[4].')';
+				return 'rgba('.$r.','.$g.','.$b.','.$value[4].')';
 			}
-			return sprintf("#%02x%02x%02x", round($value[1]), round($value[2]), round($value[3]));
+			return sprintf("#%02x%02x%02x", $r, $g, $b);
 		case 'function':
 			// [1] - function name
 			// [2] - some array value representing arguments, either ['string', value] or ['list', ',', values[]]
diff --git a/tests/outputs/colors.css b/tests/outputs/colors.css
@@ -1,24 +1,24 @@
 body {
   color:#996d33;
-  color:rgba(153,108.8,51,0.3);
+  color:rgba(153,109,51,0.3);
   lighten:#ffffff;
   lighten:#7c8df2;
-  lighten:rgba(222.44285714286,139.91428571429,128.55714285714,0.5);
+  lighten:rgba(222,140,129,0.5);
   darken:#d6d6d6;
   darken:#0d1e81;
-  darken:rgba(18.38188976378,42.358267716535,184.61811023622,0.5);
+  darken:rgba(18,42,185,0.5);
   saturate:#f1eded;
   saturate:#0025fe;
-  saturate:rgba(10.3,43.963461538462,243.7,0.5);
+  saturate:rgba(10,44,244,0.5);
   desaturate:#efefef;
   desaturate:#3349cb;
-  desaturate:rgba(35.7,62.036538461538,218.3,0.5);
+  desaturate:rgba(36,62,218,0.5);
   spin:#efefef;
   spin:#2d17e7;
-  spin:rgba(58.866666666667,23,231,0.5);
+  spin:rgba(59,23,231,0.5);
   spin:#efefef;
   spin:#1769e7;
-  spin:rgba(23,118.86666666667,231,0.5);
+  spin:rgba(23,119,231,0.5);
   one:#abcdef;
   one:#abcdef;
   two:rgba(2,159,35,0.9);
