don't write colors with alpha as 1 with rgba

leafo · leafo · commit 0b8aa30fd893 · 2012-02-25T11:50:05.000-08:00
diff --git a/lessc.inc.php b/lessc.inc.php
@@ -1369,7 +1369,7 @@ function compileValue($value) {
 			// [2] - green component
 			// [3] - blue component
 			// [4] - optional alpha component
-			if (count($value) == 5) { // rgba
+			if (count($value) == 5 && $value[4] != 1) { // rgba
 				return 'rgba('.$value[1].','.$value[2].','.$value[3].','.$value[4].')';
 			}
 			return sprintf("#%02x%02x%02x", round($value[1]), round($value[2]), round($value[3]));
diff --git a/tests/outputs/colors.css b/tests/outputs/colors.css
@@ -19,8 +19,8 @@ body {
   spin:#efefef;
   spin:#1769e7;
   spin:rgba(23,118.86666666667,231,0.5);
-  one:rgba(171,205,239,1);
-  one:rgba(171,205,239,1);
+  one:#abcdef;
+  one:#abcdef;
   two:rgba(2,159,35,0.9);
   two:rgba(2,159,35,0.9);
   three:rgba(1,2,3,0.6);

Original file line number	Diff line number	Diff line change
`@@ -1369,7 +1369,7 @@ function compileValue($value) {`
`1369`	`1369`	`// [2] - green component`
`1370`	`1370`	`// [3] - blue component`
`1371`	`1371`	`// [4] - optional alpha component`
`1372`		`- if (count($value) == 5) { // rgba`
	`1372`	`+ if (count($value) == 5 && $value[4] != 1) { // rgba`
`1373`	`1373`	`return 'rgba('.$value[1].','.$value[2].','.$value[3].','.$value[4].')';`
`1374`	`1374`	`}`
`1375`	`1375`	`return sprintf("#%02x%02x%02x", round($value[1]), round($value[2]), round($value[3]));`