Add field increment (firebase#13)

samtstern · web-flow · commit fef57ce7b9b3 · 2019-03-21T14:22:50.000-07:00
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -105,11 +105,7 @@ Before you submit your pull request consider the following guidelines:
      ```
   Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
 
-* Build your changes locally to ensure all the tests pass:
-
-    ```shell
-   gulp
-    ```
+* Open the local index.html file in your browser to ensure all the tests pass.
 
 * Push your branch to GitHub:
 
diff --git a/firestore/index.html b/firestore/index.html
@@ -12,8 +12,8 @@
 
   <script>mocha.setup('bdd')</script>
 
-  <script src="https://www.gstatic.com/firebasejs/5.5.5/firebase.js"></script>
-  <script src="https://www.gstatic.com/firebasejs/5.5.5/firebase-firestore.js"></script>
+  <script src="https://www.gstatic.com/firebasejs/5.9.0/firebase.js"></script>
+  <script src="https://www.gstatic.com/firebasejs/5.9.0/firebase-firestore.js"></script>
   <script src="test.firestore.js"></script>
   <script src="test.solution-arrays.js"></script>
   <script src="test.solution-counters.js"></script>
diff --git a/firestore/test.firestore.js b/firestore/test.firestore.js
@@ -423,6 +423,18 @@ describe("firestore", () => {
             // [END update_document_array]
         });
 
+        it("should update a document using numeric transforms", () => {
+            // [START update_document_increment]
+            var washingtonRef = db.collection('cities').doc('DC');
+
+            // Atomically increment the population of the city by 50.
+            // Note that increment() with no arguments increments by 1.
+            washingtonRef.update({
+                population: firebase.firestore.FieldValue.increment(50)
+            });
+            // [END update_document_increment]
+        })
+
         it("should delete a document", () => {
             return output =
             // [START delete_document]
@@ -450,6 +462,9 @@ describe("firestore", () => {
                             throw "Document does not exist!";
                         }
 
+                        // Add one person to the city population.
+                        // Note: this could be done without a transaction
+                        //       by updating the population using FieldValue.increment()
                         var newPopulation = sfDoc.data().population + 1;
                         transaction.update(sfDocRef, { population: newPopulation });
                     });
