Skip to content

Commit 5d61603

Browse files
committed
Fix tests for bitly, urlborg, and digg.
1 parent ff79415 commit 5d61603

File tree

6 files changed

+59
-1
lines changed

6 files changed

+59
-1
lines changed

imports.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from urlparse import urlparse
99
from random import randint
1010
import base64
11+
from getpass import getpass
1112

1213
try:
1314
import json

services/bitly.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,19 @@ def __init__(self, login=None, apikey=None, password=None):
1212
self.apikey = apikey
1313
self.password = password
1414

15+
def _test(self):
16+
# prompt for login
17+
self.login = raw_input('bitly login: ')
18+
19+
# ask if tester wants to provide apikey or password
20+
print 'auth with password(P) or apikey(K)?'
21+
if raw_input() == 'P':
22+
self.password = getpass('bitly password: ')
23+
else:
24+
self.apikey = raw_input('bitly apikey: ')
25+
26+
Service._test(self)
27+
1528
def _setup(self):
1629
parameters = {'version': self.version}
1730
if self.apikey:

services/digg.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ def __init__(self, appkey=None):
1010
self.itemid = None
1111
self.view_count = None
1212

13+
def _test(self):
14+
self.appkey = 'http://gitorious.org/shorty'
15+
Service._test(self)
16+
1317
def shrink(self, bigurl):
1418
if not self.appkey:
1519
raise ShortyError('Must set an appkey')

services/urlborg.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ class Urlborg(Service):
88
def __init__(self, apikey=None):
99
self.apikey = apikey
1010

11+
def _test(self):
12+
# prompt tester for apikey
13+
self.apikey = raw_input('urlborg apikey: ').strip()
14+
Service._test(self)
15+
1116
def shrink(self, bigurl):
1217
if not self.apikey:
1318
raise ShortyError('Must set an apikey')

shorty.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
from urlparse import urlparse
4343
from random import randint
4444
import base64
45+
from getpass import getpass
4546

4647
try:
4748
import json
@@ -157,6 +158,11 @@ class Urlborg(Service):
157158
def __init__(self, apikey=None):
158159
self.apikey = apikey
159160

161+
def _test(self):
162+
# prompt tester for apikey
163+
self.apikey = raw_input('urlborg apikey: ').strip()
164+
Service._test(self)
165+
160166
def shrink(self, bigurl):
161167
if not self.apikey:
162168
raise ShortyError('Must set an apikey')
@@ -296,6 +302,19 @@ def __init__(self, login=None, apikey=None, password=None):
296302
self.apikey = apikey
297303
self.password = password
298304

305+
def _test(self):
306+
# prompt for login
307+
self.login = raw_input('bitly login: ')
308+
309+
# ask if tester wants to provide apikey or password
310+
print 'auth with password(P) or apikey(K)?'
311+
if raw_input() == 'P':
312+
self.password = getpass('bitly password: ')
313+
else:
314+
self.apikey = raw_input('bitly apikey: ')
315+
316+
Service._test(self)
317+
299318
def _setup(self):
300319
parameters = {'version': self.version}
301320
if self.apikey:
@@ -411,6 +430,10 @@ def __init__(self, appkey=None):
411430
self.itemid = None
412431
self.view_count = None
413432

433+
def _test(self):
434+
self.appkey = 'http://gitorious.org/shorty'
435+
Service._test(self)
436+
414437
def shrink(self, bigurl):
415438
if not self.appkey:
416439
raise ShortyError('Must set an appkey')

test.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,27 @@
22
# Copyright 2009 Joshua Roesslein
33
# See LICENSE
44

5+
import sys
6+
57
import shorty
68

79
print 'Running shorty tests...'
810

911
passes = 0
1012
fails = 0
1113

12-
for name, service in shorty.services.items():
14+
# get services to test
15+
if len(sys.argv) > 1:
16+
try:
17+
services = dict((name, shorty.services[name]) for name in sys.argv[1:])
18+
except KeyError, k:
19+
print 'ERROR: %s not valid service' % k
20+
exit(1)
21+
else:
22+
services = shorty.services
1323

24+
# run tests
25+
for name, service in services.items():
1426
try:
1527
if service.tested:
1628
# skip services with aliases

0 commit comments

Comments
 (0)