fix(e2e): shouldn't install webdrivers for unchecked browsers on creation (vuejs#5736)

haoqunjiang · web-flow · commit 1030f3959907 · 2020-08-03T15:20:29.000+08:00
diff --git a/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js b/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js
@@ -54,7 +54,9 @@ test('nightwatch', async () => {
 
   const expectedOptions = {
     plugins: {
-      '@vue/cli-plugin-e2e-nightwatch': {}
+      '@vue/cli-plugin-e2e-nightwatch': {
+        webdrivers: ['chrome', 'firefox']
+      }
     }
   }
 
@@ -87,7 +89,9 @@ test('webdriverio', async () => {
 
   const expectedOptions = {
     plugins: {
-      '@vue/cli-plugin-e2e-webdriverio': {}
+      '@vue/cli-plugin-e2e-webdriverio': {
+        webdrivers: ['chrome', 'firefox']
+      }
     }
   }
 
diff --git a/packages/@vue/cli/lib/promptModules/e2e.js b/packages/@vue/cli/lib/promptModules/e2e.js
@@ -58,9 +58,13 @@ module.exports = cli => {
     if (answers.e2e === 'cypress') {
       options.plugins['@vue/cli-plugin-e2e-cypress'] = {}
     } else if (answers.e2e === 'nightwatch') {
-      options.plugins['@vue/cli-plugin-e2e-nightwatch'] = {}
+      options.plugins['@vue/cli-plugin-e2e-nightwatch'] = {
+        webdrivers: answers.webdrivers
+      }
     } else if (answers.e2e === 'webdriverio') {
-      options.plugins['@vue/cli-plugin-e2e-webdriverio'] = {}
+      options.plugins['@vue/cli-plugin-e2e-webdriverio'] = {
+        webdrivers: answers.webdrivers
+      }
     }
   })
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ test('nightwatch', async () => {`
`54`	`54`
`55`	`55`	`const expectedOptions = {`
`56`	`56`	`plugins: {`
`57`		`- '@vue/cli-plugin-e2e-nightwatch': {}`
	`57`	`+ '@vue/cli-plugin-e2e-nightwatch': {`
	`58`	`+ webdrivers: ['chrome', 'firefox']`
	`59`	`+ }`
`58`	`60`	`}`
`59`	`61`	`}`
`60`	`62`
`@@ -87,7 +89,9 @@ test('webdriverio', async () => {`
`87`	`89`
`88`	`90`	`const expectedOptions = {`
`89`	`91`	`plugins: {`
`90`		`- '@vue/cli-plugin-e2e-webdriverio': {}`
	`92`	`+ '@vue/cli-plugin-e2e-webdriverio': {`
	`93`	`+ webdrivers: ['chrome', 'firefox']`
	`94`	`+ }`
`91`	`95`	`}`
`92`	`96`	`}`
`93`	`97`