Skip to content

Commit 91f7067

Browse files
committed
[X86] Add back the assert in getImpliedFeatures that I removed in ef4cc70
I've added additional features to the table so I want to see if the bots are happier with this.
1 parent 04b85e2 commit 91f7067

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

llvm/include/llvm/Support/X86TargetParser.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,5 +230,6 @@ X86_FEATURE (RETPOLINE_INDIRECT_BRANCHES, "retpoline-indirect-branches")
230230
X86_FEATURE (RETPOLINE_INDIRECT_CALLS, "retpoline-indirect-calls")
231231
X86_FEATURE (LVI_CFI, "lvi-cfi")
232232
X86_FEATURE (LVI_LOAD_HARDENING, "lvi-load-hardening")
233+
X86_FEATURE (SESES, "seses")
233234
#undef X86_FEATURE_COMPAT
234235
#undef X86_FEATURE

llvm/lib/Support/X86TargetParser.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,7 @@ static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_BRANCHES = {};
441441
static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_CALLS = {};
442442
static constexpr FeatureBitset ImpliedFeaturesLVI_CFI = {};
443443
static constexpr FeatureBitset ImpliedFeaturesLVI_LOAD_HARDENING = {};
444+
static constexpr FeatureBitset ImpliedFeaturesSESES = {};
444445

445446
// XSAVE features are dependent on basic XSAVE.
446447
static constexpr FeatureBitset ImpliedFeaturesXSAVEC = FeatureXSAVE;
@@ -562,6 +563,7 @@ void llvm::X86::getImpliedFeatures(
562563
if (I == std::end(FeatureInfos)) {
563564
// FIXME: This shouldn't happen, but may not have all features in the table
564565
// yet.
566+
assert(false && "Feature not found in table!");
565567
return;
566568
}
567569

0 commit comments

Comments
 (0)