[libc++] Clean up scripts to setup CI on macOS

ldionne · ldionne · commit d9d20802d0ce · 2021-06-14T15:55:36.000-04:00
diff --git a/libcxx/docs/AddingNewCIJobs.rst b/libcxx/docs/AddingNewCIJobs.rst
@@ -17,7 +17,7 @@ If you need to run the job on your own machines, please follow the
 `Buildkite guide <https://buildkite.com/docs/agent/v3>`_ to setup your
 own agents. Make sure you tag your agents in a way that you'll be able
 to recognize them when defining your job below. Finally, in order for the
-agent to register itself to Buildkite, it will need a ``BUILDKITE_AGENT_TOKEN``.
+agent to register itself to Buildkite, it will need a BuildKite Agent token.
 Please contact a maintainer to get your token.
 
 Then, simply add a job to the Buildkite pipeline by editing ``libcxx/utils/ci/buildkite-pipeline.yml``.
diff --git a/libcxx/utils/ci/macos-ci-setup b/libcxx/utils/ci/macos-ci-setup
@@ -4,7 +4,10 @@
 # An additional requirement that is *not* handled by this script is the
 # installation of Xcode, which requires manual intervention.
 
-source secrets.env
+if [[ -z "${BUILDKITE_AGENT_TOKEN}" ]]; then
+  echo "The BUILDKITE_AGENT_TOKEN environment variable must be set to a BuildKite Agent token when calling this script."
+  exit 1
+fi
 
 # Install Homebrew
 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
diff --git a/libcxx/utils/ci/secrets.env b/libcxx/utils/ci/secrets.env
