Add POOL_CONNLIMIT code to "No connections available." error

dougwilson · dougwilson · commit b9c151d556d3 · 2016-01-17T00:40:22.000-05:00
closes mysqljs#1332
diff --git a/Changes.md b/Changes.md
@@ -4,6 +4,10 @@ This file is a manually maintained list of changes for each release. Feel free
 to add your changes here when sending pull requests. Also send corrections if
 you spot any mistakes.
 
+## HEAD
+
+* Add `POOL_CONNLIMIT` code to "No connections available." error #1332
+
 ## v2.10.2 (2016-01-12)
 
 * Fix exception/hang from certain SSL connection errors #1153
diff --git a/lib/Pool.js b/lib/Pool.js
@@ -62,7 +62,9 @@ Pool.prototype.getConnection = function (cb) {
 
   if (!this.config.waitForConnections) {
     return process.nextTick(function(){
-      return cb(new Error('No connections available.'));
+      var err = new Error('No connections available.');
+      err.code = 'POOL_CONNLIMIT';
+      cb(err);
     });
   }
 
diff --git a/test/unit/pool/test-connection-limit-no-wait.js b/test/unit/pool/test-connection-limit-no-wait.js
@@ -17,8 +17,8 @@ server.listen(common.fakeServerPort, function(err){
 
     pool.getConnection(function (err) {
       assert.ok(err);
-      assert.equal(err.fatal);
       assert.equal(err.message, 'No connections available.');
+      assert.equal(err.code, 'POOL_CONNLIMIT');
 
       connection.destroy();
       server.destroy();

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,9 @@ Pool.prototype.getConnection = function (cb) {`
`62`	`62`
`63`	`63`	`if (!this.config.waitForConnections) {`
`64`	`64`	`return process.nextTick(function(){`
`65`		`- return cb(new Error('No connections available.'));`
	`65`	`+ var err = new Error('No connections available.');`
	`66`	`+ err.code = 'POOL_CONNLIMIT';`
	`67`	`+ cb(err);`
`66`	`68`	`});`
`67`	`69`	`}`
`68`	`70`