Mimic bindValue and only quote non-integer and non-float data type (barryvdh#868)

Vmak11 · barryvdh · commit d7815315b2f7 · 2018-10-23T22:04:17.000+02:00
diff --git a/src/DataCollector/QueryCollector.php b/src/DataCollector/QueryCollector.php
@@ -109,7 +109,13 @@ public function addQuery($query, $bindings, $time, $connection)
                 $regex = is_numeric($key)
                     ? "/\?(?=(?:[^'\\\']*'[^'\\\']*')*[^'\\\']*$)/"
                     : "/:{$key}(?=(?:[^'\\\']*'[^'\\\']*')*[^'\\\']*$)/";
-                $query = preg_replace($regex, $pdo->quote($binding), $query, 1);
+
+                // Mimic bindValue and only quote non-integer and non-float data types
+                if (!is_int($binding) && !is_float($binding)) {
+                    $binding = $pdo->quote($binding);
+                }
+
+                $query = preg_replace($regex, $binding, $query, 1);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,13 @@ public function addQuery($query, $bindings, $time, $connection)`
`109`	`109`	`$regex = is_numeric($key)`
`110`	`110`	`? "/\?(?=(?:[^'\\\']'[^'\\\']')[^'\\\']$)/"`
`111`	`111`	`: "/:{$key}(?=(?:[^'\\\']'[^'\\\']')[^'\\\']$)/";`
`112`		`- $query = preg_replace($regex, $pdo->quote($binding), $query, 1);`
	`112`	`+`
	`113`	`+ // Mimic bindValue and only quote non-integer and non-float data types`
	`114`	`+ if (!is_int($binding) && !is_float($binding)) {`
	`115`	`+ $binding = $pdo->quote($binding);`
	`116`	`+ }`
	`117`	`+`
	`118`	`+ $query = preg_replace($regex, $binding, $query, 1);`
`113`	`119`	`}`
`114`	`120`	`}`
`115`	`121`