Return exit code properly

Tom Needham · Tom Needham · commit 960d5c49f4b5 · 2018-08-15T23:46:38.000+01:00
diff --git a/src/LaravelDeployer/Commands/BaseCommand.php b/src/LaravelDeployer/Commands/BaseCommand.php
@@ -55,7 +55,7 @@ public function dep($command)
 
         $parameters = $this->getParametersAsString($this->parameters);
         $depBinary = 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'dep';
-        $this->process("$depBinary --file=$deployFile $command $parameters");
+        return $this->process("$depBinary --file=$deployFile $command $parameters");
     }
 
     public function getDeployFile()
@@ -100,7 +100,7 @@ public function getCustomDeployFile()
 
     public function process($command)
     {
-        $process = (new Process($command))
+        return (new Process($command))
             ->setTty($this->isTtySupported())
             ->setWorkingDirectory(base_path())
             ->setTimeout(null)
diff --git a/src/LaravelDeployer/Commands/Deploy.php b/src/LaravelDeployer/Commands/Deploy.php
@@ -9,6 +9,6 @@ class Deploy extends BaseCommand
 
     public function handle()
     {
-        $this->dep('deploy');
+        return $this->dep('deploy');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployConfigs.php b/src/LaravelDeployer/Commands/DeployConfigs.php
@@ -9,6 +9,6 @@ class DeployConfigs extends BaseCommand
 
     public function handle()
     {
-        $this->dep('config:dump');
+        return $this->dep('config:dump');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployCurrent.php b/src/LaravelDeployer/Commands/DeployCurrent.php
@@ -9,6 +9,6 @@ class DeployCurrent extends BaseCommand
 
     public function handle()
     {
-        $this->dep('config:current');
+        return $this->dep('config:current');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployDump.php b/src/LaravelDeployer/Commands/DeployDump.php
@@ -9,6 +9,6 @@ class DeployDump extends BaseCommand
 
     public function handle()
     {
-        $this->dep('debug:task');
+        return $this->dep('debug:task');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployHosts.php b/src/LaravelDeployer/Commands/DeployHosts.php
@@ -9,6 +9,6 @@ class DeployHosts extends BaseCommand
 
     public function handle()
     {
-        $this->dep('config:hosts');
+        return $this->dep('config:hosts');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployList.php b/src/LaravelDeployer/Commands/DeployList.php
@@ -14,6 +14,6 @@ class DeployList extends BaseCommand
 
     public function handle()
     {
-        $this->dep('list');
+        return $this->dep('list');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployRollback.php b/src/LaravelDeployer/Commands/DeployRollback.php
@@ -9,6 +9,6 @@ class DeployRollback extends BaseCommand
 
     public function handle()
     {
-        $this->dep('rollback');
+        return $this->dep('rollback');
     }
 }
diff --git a/src/LaravelDeployer/Commands/DeployRun.php b/src/LaravelDeployer/Commands/DeployRun.php
@@ -10,6 +10,6 @@ class DeployRun extends BaseCommand
     public function handle()
     {
         // Task will be executed as a direct command of `dep`.
-        $this->dep('');
+        return $this->dep('');
     }
 }
diff --git a/src/LaravelDeployer/Commands/Logs.php b/src/LaravelDeployer/Commands/Logs.php
@@ -9,6 +9,6 @@ class Logs extends BaseCommand
 
     public function handle()
     {
-        $this->dep('logs');
+        return $this->dep('logs');
     }
 }
diff --git a/src/LaravelDeployer/Commands/Ssh.php b/src/LaravelDeployer/Commands/Ssh.php
@@ -9,6 +9,6 @@ class Ssh extends BaseCommand
 
     public function handle()
     {
-        $this->dep('ssh');
+        return $this->dep('ssh');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function dep($command)`
`55`	`55`
`56`	`56`	`$parameters = $this->getParametersAsString($this->parameters);`
`57`	`57`	`$depBinary = 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'dep';`
`58`		`- $this->process("$depBinary --file=$deployFile $command $parameters");`
	`58`	`+ return $this->process("$depBinary --file=$deployFile $command $parameters");`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public function getDeployFile()`
`@@ -100,7 +100,7 @@ public function getCustomDeployFile()`
`100`	`100`
`101`	`101`	`public function process($command)`
`102`	`102`	`{`
`103`		`- $process = (new Process($command))`
	`103`	`+ return (new Process($command))`
`104`	`104`	`->setTty($this->isTtySupported())`
`105`	`105`	`->setWorkingDirectory(base_path())`
`106`	`106`	`->setTimeout(null)`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class Deploy extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('deploy');`
	`12`	`+ return $this->dep('deploy');`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class DeployConfigs extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('config:dump');`
	`12`	`+ return $this->dep('config:dump');`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class DeployCurrent extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('config:current');`
	`12`	`+ return $this->dep('config:current');`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class DeployDump extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('debug:task');`
	`12`	`+ return $this->dep('debug:task');`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class DeployHosts extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('config:hosts');`
	`12`	`+ return $this->dep('config:hosts');`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@ class DeployList extends BaseCommand`
`14`	`14`
`15`	`15`	`public function handle()`
`16`	`16`	`{`
`17`		`- $this->dep('list');`
	`17`	`+ return $this->dep('list');`
`18`	`18`	`}`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class DeployRollback extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('rollback');`
	`12`	`+ return $this->dep('rollback');`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,6 @@ class DeployRun extends BaseCommand`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`	`12`	// Task will be executed as a direct command of `dep`.
`13`		`- $this->dep('');`
	`13`	`+ return $this->dep('');`
`14`	`14`	`}`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ class Logs extends BaseCommand`
`9`	`9`
`10`	`10`	`public function handle()`
`11`	`11`	`{`
`12`		`- $this->dep('logs');`
	`12`	`+ return $this->dep('logs');`
`13`	`13`	`}`
`14`	`14`	`}`