Merge pull request laravel#1056 from Jakobud/bug/form/buttons/defaultValues

taylorotwell · taylorotwell · commit 017c65c0bc62 · 2012-09-01T17:35:34.000-07:00
Fixed Exception thrown when passing null $value to Form::submit(), Form::reset(), Form::button()
diff --git a/laravel/form.php b/laravel/form.php
@@ -526,7 +526,7 @@ protected static function checkable($type, $name, $value, $checked, $attributes)
 	 * @param  array   $attributes
 	 * @return string
 	 */
-	public static function submit($value, $attributes = array())
+	public static function submit($value = null, $attributes = array())
 	{
 		return static::input('submit', null, $value, $attributes);
 	}
@@ -538,7 +538,7 @@ public static function submit($value, $attributes = array())
 	 * @param  array   $attributes
 	 * @return string
 	 */
-	public static function reset($value, $attributes = array())
+	public static function reset($value = null, $attributes = array())
 	{
 		return static::input('reset', null, $value, $attributes);
 	}
@@ -570,7 +570,7 @@ public static function image($url, $name = null, $attributes = array())
 	 * @param  array   $attributes
 	 * @return string
 	 */
-	public static function button($value, $attributes = array())
+	public static function button($value = null, $attributes = array())
 	{
 		return '<button'.HTML::attributes($attributes).'>'.HTML::entities($value).'</button>';
 	}

Original file line number	Diff line number	Diff line change
`@@ -526,7 +526,7 @@ protected static function checkable($type, $name, $value, $checked, $attributes)`
`526`	`526`	`* @param array $attributes`
`527`	`527`	`* @return string`
`528`	`528`	`*/`
`529`		`- public static function submit($value, $attributes = array())`
	`529`	`+ public static function submit($value = null, $attributes = array())`
`530`	`530`	`{`
`531`	`531`	`return static::input('submit', null, $value, $attributes);`
`532`	`532`	`}`
`@@ -538,7 +538,7 @@ public static function submit($value, $attributes = array())`
`538`	`538`	`* @param array $attributes`
`539`	`539`	`* @return string`
`540`	`540`	`*/`
`541`		`- public static function reset($value, $attributes = array())`
	`541`	`+ public static function reset($value = null, $attributes = array())`
`542`	`542`	`{`
`543`	`543`	`return static::input('reset', null, $value, $attributes);`
`544`	`544`	`}`
`@@ -570,7 +570,7 @@ public static function image($url, $name = null, $attributes = array())`
`570`	`570`	`* @param array $attributes`
`571`	`571`	`* @return string`
`572`	`572`	`*/`
`573`		`- public static function button($value, $attributes = array())`
	`573`	`+ public static function button($value = null, $attributes = array())`
`574`	`574`	`{`
`575`	`575`	`return '<button'.HTML::attributes($attributes).'>'.HTML::entities($value).'</button>';`
`576`	`576`	`}`