feat: Internal environment ID support. #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-for-2.x-event-source
Base automatically changed from
rlamb/o11y-add-environment-id-support
to
main
September 3, 2025 20:46
…darkly/flutter-client-sdk into rlamb/update-for-2.x-event-source
kinyoklion
commented
Sep 4, 2025
There was a problem hiding this comment.
Removing temporary changes from the major versioning of the event source client.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tanderson-ld
reviewed
Sep 5, 2025
| // (credential). | ||
| if (_store.environmentId != null) { | ||
| await _persistence?.set( | ||
| _environmentKey, _envIdKey, _store.environmentId!); |
There was a problem hiding this comment.
Is this bang avoidable?
There was a problem hiding this comment.
It is checked before, but the dart compiler still wanted it. I think because maybe it doesn't know the parameter evaluation happens before the async operation.
tanderson-ld
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propagates the environment ID internal to the common client.
A subsequent PR will add hooks support and utilize this environment ID support.