renaming of highest speed

LazyTesting · LazyTesting · commit 03c49c72f98c · 2017-01-28T10:24:23.000+01:00
diff --git a/core/calculate-angle/app.js b/core/calculate-angle/app.js
@@ -9,8 +9,6 @@ const get = function Get(pos1, pos2) {
     return calculateAngle(vertical, horizontal);
 };
 
-
-// TODO check axis
 const calculateAngle = function(x, y)
 {
     const tan = Math.atan2(x, y);
diff --git a/core/calculate-angle/spec.js b/core/calculate-angle/spec.js
@@ -1,14 +1,15 @@
 const assert = require('assert');
 const angle = require('./app.js');
 
-const pos1 = { lat: '46.974974', lon: '10.311162', ele: 13 };
-const pos2 = { lat: '46.97495', lon: '10.311144', ele: 10 };
+const pos1 = { lat: '46.975419', lon: '10.311633', ele: 13 };
+const pos2 = { lat: '46.975569', lon: '10.31181', ele: 6 };
 
 describe('calculate angle between to points', () => {
 
     it('should return a positive number', () => {
         const result = angle(pos1, pos2);
-        assert(result > 0);
+        assert(result > 17);
+        assert(result < 19);
     });
 });
 
diff --git a/engine/highest-downhill-slope-angle/spec.js b/engine/highest-downhill-slope-angle/spec.js
@@ -7,7 +7,7 @@ describe('Read and parse data from disk', () => {
     it('should return results', () => {
         const filePath = path.join(__dirname, '/test/data.gpx');
         const gpx = fs.readFileSync(filePath, 'utf8');
-        const result = angle(gpx, 5);
+        const result = angle(gpx, 15);
         console.log(result);
         assert.ok(result > 0);
     });
diff --git a/engine/highest-downhill-speed/app.js b/engine/highest-downhill-speed/app.js
@@ -29,14 +29,14 @@ const createReduce = seconds => (carry, item) => {
  * returns the total downhill distance of the track
  * @param {String} gpxContent - gpx document
  * @param {Number} seconds - timeframe to calculate average
- * @returns {Number} anlge - maximum slope angle
+ * @returns {Number} speed - maximum speed in km/h
  */
 const get = function(gpxContent, seconds) {
     const points = convertGPX(gpxContent);
     const distances = points.reduce(createReduce(seconds), [[]]);
-    const angles = distances.map(ele => speed(tdistance(ele[0], ele[ele.length - 1]), timeDiff(ele[0], ele[ele.length - 1])));
+    const speeds = distances.map(ele => speed(tdistance(ele[0], ele[ele.length - 1]), timeDiff(ele[0], ele[ele.length - 1])));
 
-    return angles.reduce((carry, item) => Math.max(carry, item), angles.shift());
+    return speeds.reduce((carry, item) => Math.max(carry, item), speeds.shift());
 };
 
 module.exports = get;
diff --git a/engine/highest-downhill-speed/package.json b/engine/highest-downhill-speed/package.json
@@ -1,6 +1,6 @@
 {
-  "name": "highest-total-speed",
-  "version": "0.1.0",
+  "name": "highest-downhill-speed",
+  "version": "0.2.0",
   "description": "",
   "main": "app.js",
   "scripts": {
diff --git a/engine/highest-downhill-speed/spec.js b/engine/highest-downhill-speed/spec.js
diff --git a/engine/highest-downhill-speed/test/data.gpx b/engine/highest-downhill-speed/test/data.gpx

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,6 @@ const get = function Get(pos1, pos2) {`
`9`	`9`	`return calculateAngle(vertical, horizontal);`
`10`	`10`	`};`
`11`	`11`
`12`		`-`
`13`		`-// TODO check axis`
`14`	`12`	`const calculateAngle = function(x, y)`
`15`	`13`	`{`
`16`	`14`	`const tan = Math.atan2(x, y);`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`		`- "name": "highest-total-speed",`
`3`		`- "version": "0.1.0",`
	`2`	`+ "name": "highest-downhill-speed",`
	`3`	`+ "version": "0.2.0",`
`4`	`4`	`"description": "",`
`5`	`5`	`"main": "app.js",`
`6`	`6`	`"scripts": {`