chore: Make the logging consistent and pretty (vuejs#1925)

pksunkara · yyx990803 · commit 17f37187f058 · 2018-07-24T10:22:13.000-04:00
diff --git a/packages/@vue/cli/lib/Creator.js b/packages/@vue/cli/lib/Creator.js
@@ -141,7 +141,6 @@ module.exports = class Creator extends EventEmitter {
     }
 
     // run generator
-    log()
     log(`🚀  Invoking generators...`)
     this.emit('creation', { event: 'invoking-generators' })
     const plugins = await this.resolvePlugins(preset.plugins)
@@ -163,7 +162,6 @@ module.exports = class Creator extends EventEmitter {
     }
 
     // run complete cbs if any (injected by generators)
-    log()
     logWithSpinner('⚓', `Running completion hooks...`)
     this.emit('creation', { event: 'completion-hooks' })
     for (const cb of createCompleteCbs) {
diff --git a/packages/@vue/cli/lib/add.js b/packages/@vue/cli/lib/add.js
@@ -6,7 +6,6 @@ const {
   log,
   error,
   hasProjectYarn,
-  stopSpinner,
   resolvePluginId,
   resolveModule,
   loadModule
@@ -30,9 +29,6 @@ async function add (pluginName, options = {}, context = process.cwd()) {
   const packageManager = loadOptions().packageManager || (hasProjectYarn(context) ? 'yarn' : 'npm')
   await installPackage(context, packageManager, null, packageName)
 
-  stopSpinner()
-
-  log()
   log(`${chalk.green('✔')}  Successfully installed plugin: ${chalk.cyan(packageName)}`)
   log()
 
diff --git a/packages/@vue/cli/lib/invoke.js b/packages/@vue/cli/lib/invoke.js
@@ -131,6 +131,7 @@ async function runGenerator (context, plugin, pkg = getPkg(context)) {
 
   if (!isTestOrDebug && depsChanged) {
     log(`📦  Installing additional dependencies...`)
+    log()
     const packageManager =
       loadOptions().packageManager || (hasProjectYarn(context) ? 'yarn' : 'npm')
     await installDeps(context, packageManager)
@@ -141,12 +142,11 @@ async function runGenerator (context, plugin, pkg = getPkg(context)) {
     for (const cb of createCompleteCbs) {
       await cb()
     }
+    stopSpinner()
+    log()
   }
 
-  stopSpinner()
-
-  log()
-  log(`   Successfully invoked generator for plugin: ${chalk.cyan(plugin.id)}`)
+  log(`${chalk.green('✔')}  Successfully invoked generator for plugin: ${chalk.cyan(plugin.id)}`)
   if (!process.env.VUE_CLI_TEST && hasProjectGit(context)) {
     const { stdout } = await execa('git', [
       'ls-files',

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,6 @@ module.exports = class Creator extends EventEmitter {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`// run generator`
`144`		`- log()`
`145`	`144`	log(`🚀 Invoking generators...`)
`146`	`145`	`this.emit('creation', { event: 'invoking-generators' })`
`147`	`146`	`const plugins = await this.resolvePlugins(preset.plugins)`
`@@ -163,7 +162,6 @@ module.exports = class Creator extends EventEmitter {`
`163`	`162`	`}`
`164`	`163`
`165`	`164`	`// run complete cbs if any (injected by generators)`
`166`		`- log()`
`167`	`165`	logWithSpinner('⚓', `Running completion hooks...`)
`168`	`166`	`this.emit('creation', { event: 'completion-hooks' })`
`169`	`167`	`for (const cb of createCompleteCbs) {`