fix(create): fix shouldInitGit check (vuejs#1901)

haoqunjiang · yyx990803 · commit 7e6c37c09bfd · 2018-07-20T06:38:07.000-07:00
Also improve skip git flag description (`--git false` -&gt; `--no-git`)
diff --git a/packages/@vue/cli/bin/vue.js b/packages/@vue/cli/bin/vue.js
@@ -49,7 +49,8 @@ program
   .option('-i, --inlinePreset <json>', 'Skip prompts and use inline JSON string as preset')
   .option('-m, --packageManager <command>', 'Use specified npm client when installing dependencies')
   .option('-r, --registry <url>', 'Use specified npm registry when installing dependencies (only for npm)')
-  .option('-g, --git [message]', 'Force / skip git initialization, optionally specify initial commit message')
+  .option('-g, --git [message]', 'Force git initialization with optional initial commit message')
+  .option('-n, --no-git', 'Skip git initialization')
   .option('-f, --force', 'Overwrite target directory if it exists')
   .option('-c, --clone', 'Use git clone when fetching remote preset')
   .option('-x, --proxy', 'Use specified proxy when creating project')
@@ -187,7 +188,7 @@ function cleanArgs (cmd) {
     const key = o.long.replace(/^--/, '')
     // if an option is not present and Command has a method with the same name
     // it should not be copied
-    if (typeof cmd[key] !== 'function') {
+    if (typeof cmd[key] !== 'function' && typeof cmd[key] !== 'undefined') {
       args[key] = cmd[key]
     }
   })
diff --git a/packages/@vue/cli/lib/Creator.js b/packages/@vue/cli/lib/Creator.js
@@ -440,7 +440,7 @@ module.exports = class Creator extends EventEmitter {
     if (!hasGit()) {
       return false
     }
-    if (cliOptions.git) {
+    if (typeof cliOptions.git !== 'undefined') {
       return cliOptions.git !== 'false' && cliOptions.git !== false
     }
 

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,7 @@ module.exports = class Creator extends EventEmitter {`
`440`	`440`	`if (!hasGit()) {`
`441`	`441`	`return false`
`442`	`442`	`}`
`443`		`- if (cliOptions.git) {`
	`443`	`+ if (typeof cliOptions.git !== 'undefined') {`
`444`	`444`	`return cliOptions.git !== 'false' && cliOptions.git !== false`
`445`	`445`	`}`
`446`	`446`