fix: fix Promise.finally missing in Firefox

yyx990803 · yyx990803 · commit b20f624c32a5 · 2018-08-03T13:35:07.000-07:00
fix vuejs#2012
diff --git a/packages/@vue/babel-preset-app/README.md b/packages/@vue/babel-preset-app/README.md
@@ -76,7 +76,7 @@ See [@babel/preset-env docs](https://new.babeljs.io/docs/en/next/babel-preset-en
 
 ### polyfills
 
-- Default: `['es6.promise', 'es6.array.iterator']`
+- Default: `['es6.array.iterator', 'es6.promise', 'es7.promise.finally']`
 
 A list of [core-js](https://github.com/zloirock/core-js) polyfills to pre-include when using `useBuiltIns: 'usage'`. **These polyfills are automatically excluded if they are not needed for your target environments**.
 
diff --git a/packages/@vue/babel-preset-app/index.js b/packages/@vue/babel-preset-app/index.js
@@ -1,10 +1,13 @@
 const path = require('path')
 
 const defaultPolyfills = [
-  'es6.promise',
   // promise polyfill alone doesn't work in IE,
   // needs this as well. see: #1642
-  'es6.array.iterator'
+  'es6.array.iterator',
+  // this is required for webpack code splitting, vuex etc.
+  'es6.promise',
+  // #2012 es6.promise replaces native Promise in FF and causes missing finally
+  'es7.promise.finally'
 ]
 
 function getPolyfills (targets, includes, { ignoreBrowserslistConfig, configPath }) {
diff --git a/packages/@vue/babel-preset-app/polyfillsPlugin.js b/packages/@vue/babel-preset-app/polyfillsPlugin.js
@@ -13,7 +13,8 @@ module.exports = ({ types }) => {
 
         const { polyfills } = state.opts
         const { createImport } = require('@babel/preset-env/lib/utils')
-        polyfills.forEach(p => {
+        // imports are injected in reverse order
+        polyfills.slice().reverse().forEach(p => {
           createImport(path, p)
         })
       }

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,8 @@ module.exports = ({ types }) => {`
`13`	`13`
`14`	`14`	`const { polyfills } = state.opts`
`15`	`15`	`const { createImport } = require('@babel/preset-env/lib/utils')`
`16`		`- polyfills.forEach(p => {`
	`16`	`+ // imports are injected in reverse order`
	`17`	`+ polyfills.slice().reverse().forEach(p => {`
`17`	`18`	`createImport(path, p)`
`18`	`19`	`})`
`19`	`20`	`}`