refactor: only place css at root when using relative baseUrl

yyx990803 · yyx990803 · commit ee82c3e53e56 · 2018-07-26T17:15:38.000-04:00
diff --git a/docs/config/README.md b/docs/config/README.md
@@ -48,7 +48,7 @@ module.exports = {
   }
   ```
 
-  The value can also be set to an empty string (`''`) so that all assets are linked using relative paths, so that the bundle can be used in a file system based environment like a Cordova hybrid app. The caveat is that this will force the generated CSS files to always be placed at the root of the output directory to ensure urls in your CSS work correctly.
+  The value can also be set to an empty string (`''`) so that all assets are linked using relative paths, so that the bundle can be used in a file system based environment like a Cordova hybrid app. **Note that this will force the generated CSS files to always be placed at the root of the output directory to ensure urls in your CSS work correctly.**
 
   ::: tip
   Always use `baseUrl` instead of modifying webpack `output.publicPath`.
diff --git a/packages/@vue/cli-service/lib/config/prod.js b/packages/@vue/cli-service/lib/config/prod.js
@@ -5,8 +5,7 @@ module.exports = (api, options) => {
       const getAssetPath = require('../util/getAssetPath')
       const filename = getAssetPath(
         options,
-        `js/[name]${isLegacyBundle ? `-legacy` : ``}.[chunkhash:8].js`,
-        true /* placeAtRootIfRelative */
+        `js/[name]${isLegacyBundle ? `-legacy` : ``}.[chunkhash:8].js`
       )
 
       webpackConfig

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ module.exports = {`
`48`	`48`	`}`
`49`	`49`	```
`50`	`50`
`51`		- The value can also be set to an empty string (`''`) so that all assets are linked using relative paths, so that the bundle can be used in a file system based environment like a Cordova hybrid app. The caveat is that this will force the generated CSS files to always be placed at the root of the output directory to ensure urls in your CSS work correctly.
	`51`	+ The value can also be set to an empty string (`''`) so that all assets are linked using relative paths, so that the bundle can be used in a file system based environment like a Cordova hybrid app. Note that this will force the generated CSS files to always be placed at the root of the output directory to ensure urls in your CSS work correctly.
`52`	`52`
`53`	`53`	`::: tip`
`54`	`54`	Always use `baseUrl` instead of modifying webpack `output.publicPath`.
Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,7 @@ module.exports = (api, options) => {`
`5`	`5`	`const getAssetPath = require('../util/getAssetPath')`
`6`	`6`	`const filename = getAssetPath(`
`7`	`7`	`options,`
`8`		- `js/[name]${isLegacyBundle ? `-legacy` : ``}.[chunkhash:8].js`,
`9`		`- true /* placeAtRootIfRelative */`
	`8`	+ `js/[name]${isLegacyBundle ? `-legacy` : ``}.[chunkhash:8].js`
`10`	`9`	`)`
`11`	`10`
`12`	`11`	`webpackConfig`