type-safety use of in_array()

frankmayer · frankmayer · commit 9c181126a3c1 · 2016-10-25T19:55:23.000+03:00
diff --git a/lib/triagens/ArangoDb/Collection.php b/lib/triagens/ArangoDb/Collection.php
@@ -539,7 +539,7 @@ public function setStatus($status)
                 self::STATUS_LOADED,
                 self::STATUS_BEING_UNLOADED,
                 self::STATUS_DELETED
-            ]
+            ], true
         )
         ) {
             throw new ClientException('Invalid status used for collection');
diff --git a/lib/triagens/ArangoDb/ConnectionOptions.php b/lib/triagens/ArangoDb/ConnectionOptions.php
@@ -393,15 +393,15 @@ private function validate()
 
         if (isset($this->_values[self::OPTION_AUTH_TYPE]) && !in_array(
                 $this->_values[self::OPTION_AUTH_TYPE],
-                self::getSupportedAuthTypes()
+                self::getSupportedAuthTypes(), true
             )
         ) {
             throw new ClientException('unsupported authorization method');
         }
 
         if (isset($this->_values[self::OPTION_CONNECTION]) && !in_array(
                 $this->_values[self::OPTION_CONNECTION],
-                self::getSupportedConnectionTypes()
+                self::getSupportedConnectionTypes(), true
             )
         ) {
             throw new ClientException(
diff --git a/lib/triagens/ArangoDb/Document.php b/lib/triagens/ArangoDb/Document.php
@@ -455,7 +455,7 @@ public function getAll($options = [])
 
         if ($includeInternals === true) {
             foreach ($this as $key => $value) {
-                if ($key[0] === '_' && 0 !== strpos($key, '__') && !in_array($key, $nonInternals)) {
+                if ($key[0] === '_' && 0 !== strpos($key, '__') && !in_array($key, $nonInternals, true)) {
                     $data[$key] = $value;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,7 @@ public function setStatus($status)`
`539`	`539`	`self::STATUS_LOADED,`
`540`	`540`	`self::STATUS_BEING_UNLOADED,`
`541`	`541`	`self::STATUS_DELETED`
`542`		`- ]`
	`542`	`+ ], true`
`543`	`543`	`)`
`544`	`544`	`) {`
`545`	`545`	`throw new ClientException('Invalid status used for collection');`
Original file line number	Diff line number	Diff line change
`@@ -393,15 +393,15 @@ private function validate()`
`393`	`393`
`394`	`394`	`if (isset($this->_values[self::OPTION_AUTH_TYPE]) && !in_array(`
`395`	`395`	`$this->_values[self::OPTION_AUTH_TYPE],`
`396`		`- self::getSupportedAuthTypes()`
	`396`	`+ self::getSupportedAuthTypes(), true`
`397`	`397`	`)`
`398`	`398`	`) {`
`399`	`399`	`throw new ClientException('unsupported authorization method');`
`400`	`400`	`}`
`401`	`401`
`402`	`402`	`if (isset($this->_values[self::OPTION_CONNECTION]) && !in_array(`
`403`	`403`	`$this->_values[self::OPTION_CONNECTION],`
`404`		`- self::getSupportedConnectionTypes()`
	`404`	`+ self::getSupportedConnectionTypes(), true`
`405`	`405`	`)`
`406`	`406`	`) {`
`407`	`407`	`throw new ClientException(`
Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,7 @@ public function getAll($options = [])`
`455`	`455`
`456`	`456`	`if ($includeInternals === true) {`
`457`	`457`	`foreach ($this as $key => $value) {`
`458`		`- if ($key[0] === '_' && 0 !== strpos($key, '__') && !in_array($key, $nonInternals)) {`
	`458`	`+ if ($key[0] === '_' && 0 !== strpos($key, '__') && !in_array($key, $nonInternals, true)) {`
`459`	`459`	`$data[$key] = $value;`
`460`	`460`	`}`
`461`	`461`	`}`