Log warning if deploy key is found in compose project

allisaurus · allisaurus · commit 60dafde8fd40 · 2018-06-04T10:55:48.000-07:00
diff --git a/ecs-cli/modules/cli/compose/project/project_parseV3.go b/ecs-cli/modules/cli/compose/project/project_parseV3.go
@@ -3,6 +3,7 @@ package project
 import (
 	"io/ioutil"
 	"path/filepath"
+	"reflect"
 
 	"github.com/aws/amazon-ecs-cli/ecs-cli/modules/cli/compose/containerconfig"
 	"github.com/aws/amazon-ecs-cli/ecs-cli/modules/utils/compose"
@@ -168,7 +169,8 @@ func convertToContainerConfig(serviceConfig types.ServiceConfig) (*containerconf
 		c.MountPoints = mountPoints
 	}
 
-	// TODO: add Environtment, EnvFile to ContainerConfig
+	logWarningForDeployFields(serviceConfig.Deploy, serviceConfig.Name)
+
 	// TODO: log out unsupported fields
 	return c, nil
 }
@@ -192,3 +194,17 @@ func convertPortConfigToECSMapping(portConfig types.ServicePortConfig) *ecs.Port
 	}
 	return &ecsMapping
 }
+
+func logWarningForDeployFields(d types.DeployConfig, serviceName string) {
+	if d.Resources.Limits != nil || d.Resources.Reservations != nil {
+		log.WithFields(log.Fields{
+			"option name":  "deploy",
+			"service name": serviceName,
+		}).Warn("Skipping unsupported YAML option for service... service-level resources should be configured in the ecs-param.yml file.")
+	} else if !reflect.DeepEqual(d, types.DeployConfig{}) {
+		log.WithFields(log.Fields{
+			"option name":  "deploy",
+			"service name": serviceName,
+		}).Warn("Skipping unsupported YAML option for service...")
+	}
+}
