Add tests for secretsmanager client

allisaurus · allisaurus · commit 8875a8ff0886 · 2018-08-08T16:16:23.000-07:00
diff --git a/ecs-cli/modules/clients/aws/secretsmanager/client.go b/ecs-cli/modules/clients/aws/secretsmanager/client.go
@@ -28,19 +28,21 @@ type SMClient interface {
 
 type secretsManagerClient struct {
 	client secretsmanageriface.SecretsManagerAPI
+	config *config.CommandConfig
 }
 
 // NewSecretsManagerClient creates an instance of an secretsManagerClient
 func NewSecretsManagerClient(config *config.CommandConfig) SMClient {
 	client := secretsmanager.New(config.Session)
 	client.Handlers.Build.PushBackNamed(clients.CustomUserAgentHandler())
 
-	return newClient(client)
+	return newClient(config, client)
 }
 
-func newClient(client secretsmanageriface.SecretsManagerAPI) SMClient {
+func newClient(config *config.CommandConfig, client secretsmanageriface.SecretsManagerAPI) SMClient {
 	return &secretsManagerClient{
 		client: client,
+		config: config,
 	}
 }
 
diff --git a/ecs-cli/modules/clients/aws/secretsmanager/client_test.go b/ecs-cli/modules/clients/aws/secretsmanager/client_test.go
@@ -11,4 +11,96 @@
 // express or implied. See the License for the specific language governing
 // permissions and limitations under the License.
 
-package secretsmanager
+package secretsmanager
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/aws/amazon-ecs-cli/ecs-cli/modules/clients/aws/secretsmanager/mock/sdk"
+	"github.com/aws/amazon-ecs-cli/ecs-cli/modules/config"
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/secretsmanager"
+	"github.com/golang/mock/gomock"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCreateSecret(t *testing.T) {
+	mockSM, client := setupTestController(t)
+
+	expectedInput := secretsmanager.CreateSecretInput{
+		Name:         aws.String("some-secret"),
+		SecretString: aws.String("{\"username\":\"bob\"},{\"password\":\"abc123xyz456\"}"),
+	}
+	expectedOutput := secretsmanager.CreateSecretOutput{
+		ARN:  aws.String("arn:aws:secretsmanager:some-secret-123"),
+		Name: aws.String("some-secret"),
+	}
+	mockSM.EXPECT().CreateSecret(&expectedInput).Return(&expectedOutput, nil)
+
+	output, err := client.CreateSecret(expectedInput)
+	assert.NoError(t, err, "Expected no error when Creating Secret")
+	assert.Equal(t, &expectedOutput, output, "Expected CreateSecret output to match")
+}
+
+func TestCreateSecretErrorCase(t *testing.T) {
+	mockSM, client := setupTestController(t)
+
+	mockSM.EXPECT().CreateSecret(gomock.Any()).Return(nil, errors.New("something went wrong"))
+
+	_, err := client.CreateSecret(secretsmanager.CreateSecretInput{})
+	assert.Error(t, err, "Expected error when Creating Secret")
+}
+
+func TestListSecrets(t *testing.T) {
+	mockSM, client := setupTestController(t)
+
+	secretList := []*secretsmanager.SecretListEntry{&secretsmanager.SecretListEntry{Name: aws.String("my-secret")}}
+	mockListResponse := &secretsmanager.ListSecretsOutput{
+		SecretList: secretList,
+	}
+	mockSM.EXPECT().ListSecrets(gomock.Any()).Return(mockListResponse, nil)
+
+	output, err := client.ListSecrets(nil)
+	assert.NoError(t, err, "Expected no error when listing secrets")
+	assert.NotEmpty(t, output, "Expected ListSecrets output to be non-empty")
+}
+
+func TestListSecretsWithNextToken(t *testing.T) {
+	mockSM, client := setupTestController(t)
+	tokenString := "someNextToken"
+	nextToken := &tokenString
+
+	secretList := []*secretsmanager.SecretListEntry{&secretsmanager.SecretListEntry{Name: aws.String("my-secret")}}
+	mockListResponse := &secretsmanager.ListSecretsOutput{
+		SecretList: secretList,
+	}
+	expectedInput := secretsmanager.ListSecretsInput{NextToken: nextToken}
+
+	mockSM.EXPECT().ListSecrets(&expectedInput).Return(mockListResponse, nil)
+
+	output, err := client.ListSecrets(nextToken)
+	assert.NoError(t, err, "Expected no error when listing secrets")
+	assert.NotEmpty(t, output, "Expected ListSecrets output to be non-empty")
+}
+
+func TestListSecretsErrorCase(t *testing.T) {
+	mockSM, client := setupTestController(t)
+
+	mockSM.EXPECT().ListSecrets(gomock.Any()).Return(nil, errors.New("something went wrong"))
+	_, err := client.ListSecrets(nil)
+
+	assert.Error(t, err, "Expected error when Listing Secrets")
+}
+
+func setupTestController(t *testing.T) (*mock_secretsmanageriface.MockSecretsManagerAPI, SMClient) {
+	ctrl := gomock.NewController(t)
+	mockSM := mock_secretsmanageriface.NewMockSecretsManagerAPI(ctrl)
+	mockSession, err := session.NewSession()
+	assert.NoError(t, err, "Unexpected error in creating session")
+
+	client := newClient(&config.CommandConfig{Session: mockSession}, mockSM)
+
+	return mockSM, client
+}

Original file line number	Diff line number	Diff line change
`@@ -28,19 +28,21 @@ type SMClient interface {`
`28`	`28`
`29`	`29`	`type secretsManagerClient struct {`
`30`	`30`	`client secretsmanageriface.SecretsManagerAPI`
	`31`	`+ config *config.CommandConfig`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`// NewSecretsManagerClient creates an instance of an secretsManagerClient`
`34`	`35`	`func NewSecretsManagerClient(config *config.CommandConfig) SMClient {`
`35`	`36`	`client := secretsmanager.New(config.Session)`
`36`	`37`	`client.Handlers.Build.PushBackNamed(clients.CustomUserAgentHandler())`
`37`	`38`
`38`		`- return newClient(client)`
	`39`	`+ return newClient(config, client)`
`39`	`40`	`}`
`40`	`41`
`41`		`-func newClient(client secretsmanageriface.SecretsManagerAPI) SMClient {`
	`42`	`+func newClient(config *config.CommandConfig, client secretsmanageriface.SecretsManagerAPI) SMClient {`
`42`	`43`	`return &secretsManagerClient{`
`43`	`44`	`client: client,`
	`45`	`+ config: config,`
`44`	`46`	`}`
`45`	`47`	`}`
`46`	`48`